[SM64] Fix persistent block spam #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilaa3
reviewed
Aug 23, 2024
| [^()]* | ||
| .*? # match as few chars as possible before macro name | ||
| (?P<macro_name>\w+) #group macro name matches 1+ word chars | ||
| \s* # allows any number of spaces after macro name |
There was a problem hiding this comment.
could you make this lazy (was causing extra steps according to the debugger)
Suggested change
| \s* # allows any number of spaces after macro name | |
| \s*? # allows any number of spaces after macro name |
Lilaa3
reviewed
Aug 23, 2024
| (\s*,\s*|\s*) | ||
| (?P<comment> | ||
| //.*$ | ||
| (\s*,\s*|\s*) # group of whitespace and comma and whitespace (??) |
There was a problem hiding this comment.
Suggested change
| (\s*,\s*|\s*) # group of whitespace and comma and whitespace (??) | |
| (\s*?,)?[^\n]*? # capture a comma, including white space trailing except for new lines following the comma |
| //.*$ | ||
| (\s*,\s*|\s*) # group of whitespace and comma and whitespace (??) | ||
| (?P<comment> # comment group | ||
| ([^\n]|\s*?\\\s*?\n)//.*$ # two // and any number of chars and str or line end |
There was a problem hiding this comment.
Suggested change
| ([^\n]|\s*?\\\s*?\n)//.*$ # two // and any number of chars and str or line end | |
| ([^\n]*?|\s*?\\\s*?\n)//.*$ # two // and any number of chars and str or line end |
| | | ||
| /\*.*\*/ | ||
| )? | ||
| ([^\n]|\s*?\\\s*?\n)/\*.*\*/ # a /*, any number of chars and a */ |
There was a problem hiding this comment.
Suggested change
| ([^\n]|\s*?\\\s*?\n)/\*.*\*/ # a /*, any number of chars and a */ | |
| ([^\n]*?|\s*?\\\s*?\n)/\*[\s\S]*?\*/ # a /*, any number of chars (including new line) and a */ |
Lilaa3
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macros were parsing comments even though they were on a new line, so I made the macro not see a comment with a newline character unless there was a backslash