-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM64] Fix #355 - Fix unaddressed object types in #358 #431
Conversation
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are. Previous fix was a fix to Fast-64#339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code's obviously ok, someone test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Camera volumes gave error object has no attribute to euler before, now exports without error.
puppycam volumes do not work though, but that is a separate issue. You can approve if you want or you can also fix that. Here is the error
File "C:\Users\\Desktop\fast64-main\addons\fast64\fast64_internal\sm64\sm64_objects.py", line 936, in process_sm64_objects
levelIDNames[bpy.data.scenes["Scene"].levelOption]
Sounds like something for combined exporter regressions pr to me, review that instead I will add it rn |
Well it isn't really really related to combined export but sure do it there |
It was broken by combined exporter pr, levelOption was removed in it |
Oh I was talking about the fact that it just assumes the scene name is "scene" |
Oh I'm very sorry, is it out of scope to fix it in regressions pr 😅 |
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are.
Previous fix was a fix to a #339 regression.