Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM64] Fix #355 - Fix unaddressed object types in #358 #431

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Aug 22, 2024

The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are.
Previous fix was a fix to a #339 regression.

The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are.
Previous fix was a fix to Fast-64#339
@Lilaa3 Lilaa3 added bug Something isn't working review code please Ask that some other Fast64 dev reviews the code sm64 Has to do with the Super Mario 64 side labels Aug 22, 2024
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code's obviously ok, someone test?

@Dragorn421 Dragorn421 added test please Ask that some other Fast64 dev tests the feature/... and removed review code please Ask that some other Fast64 dev reviews the code labels Aug 22, 2024
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camera volumes gave error object has no attribute to euler before, now exports without error.
puppycam volumes do not work though, but that is a separate issue. You can approve if you want or you can also fix that. Here is the error

File "C:\Users\\Desktop\fast64-main\addons\fast64\fast64_internal\sm64\sm64_objects.py", line 936, in process_sm64_objects
    levelIDNames[bpy.data.scenes["Scene"].levelOption]

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 23, 2024

Sounds like something for combined exporter regressions pr to me, review that instead I will add it rn

@Lilaa3 Lilaa3 merged commit fb91d53 into Fast-64:main Aug 23, 2024
1 check passed
@jesusyoshi54
Copy link
Collaborator

Well it isn't really really related to combined export but sure do it there

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 23, 2024

Well it isn't really really related to combined export but sure do it there

It was broken by combined exporter pr, levelOption was removed in it

@Lilaa3 Lilaa3 deleted the camera-volumes-fix branch August 23, 2024 16:40
@jesusyoshi54
Copy link
Collaborator

Oh I was talking about the fact that it just assumes the scene name is "scene"

@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 24, 2024

Oh I was talking about the fact that it just assumes the scene name is "scene"

Oh I'm very sorry, is it out of scope to fix it in regressions pr 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sm64 Has to do with the Super Mario 64 side test please Ask that some other Fast64 dev tests the feature/...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants