Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM64] Fix #421 - Custom path DL/Geolayout exports #422

Merged
merged 3 commits into from
Aug 16, 2024
Merged

[SM64] Fix #421 - Custom path DL/Geolayout exports #422

merged 3 commits into from
Aug 16, 2024

Conversation

SonicTheHedgeHog64
Copy link
Contributor

No description provided.

@SonicTheHedgeHog64 SonicTheHedgeHog64 changed the title [SM64] Fix Custom path DL/Geolayout imports [SM64] Fix Custom path DL/Geolayout exports Aug 15, 2024
@SonicTheHedgeHog64 SonicTheHedgeHog64 changed the title [SM64] Fix Custom path DL/Geolayout exports [SM64] Fix #421 - Custom path DL/Geolayout exports Aug 15, 2024
@SonicTheHedgeHog64
Copy link
Contributor Author

fixes #421

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Aug 15, 2024

As I guessed this is another combined exporter regression but I'm ok with merging this seperately, good catch

SonicTheHedgeHog64 and others added 2 commits August 15, 2024 03:49
@SonicTheHedgeHog64 @Lilaa3
Lilaa3 Suggestion
9276640 
Co-authored-by: Lila <lilaa3public@gmail.com>
@SonicTheHedgeHog64 @Lilaa3
Lilaa3 Suggestion
c2a04ea 
Co-authored-by: Lila <lilaa3public@gmail.com>
Lilaa3
Lilaa3 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thank you for contributing, I have other regressions adressed in my own pr so if you spot anymore you can check if it's been fixed in it

@Lilaa3 Lilaa3 added bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up sm64 Has to do with the Super Mario 64 side labels Aug 15, 2024
@Lilaa3 Lilaa3 merged commit 5a96c85 into Fast-64:main Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lilaa3 Lilaa3 Lilaa3 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up sm64 Has to do with the Super Mario 64 side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SonicTheHedgeHog64 @Lilaa3