Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SM64] Check actual bone type instead of group or collections #415

Merged
merged 2 commits into from
Aug 21, 2024
Merged

[SM64] Check actual bone type instead of group or collections #415

merged 2 commits into from
Aug 21, 2024

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Aug 11, 2024

No description provided.

@Lilaa3 Lilaa3 added bug Something isn't working sm64 Has to do with the Super Mario 64 side labels Aug 11, 2024
@Lilaa3 Lilaa3 marked this pull request as ready for review August 11, 2024 16:34
jesusyoshi54
jesusyoshi54 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on mario and makes sense code wise.

@Lilaa3 Lilaa3 added the merge soon Will be merged in a few days at most if nothing else comes up label Aug 20, 2024
@Dragorn421 Dragorn421 merged commit b99391e into Fast-64:main Aug 21, 2024
1 check passed
@Lilaa3 Lilaa3 deleted the dont-check-bone-collections-for-type branch August 24, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusyoshi54 jesusyoshi54 jesusyoshi54 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up sm64 Has to do with the Super Mario 64 side
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lilaa3 @jesusyoshi54 @Dragorn421