[F3D] Show tlut othermode in materials and world defaults #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mode is still automatically set when using CI textures, however the default can now be changed and it hides what's happening under the hood just a bit less, I also removed some code from f3d_bleed, specifically I removed reset_command_dict (unused) and DPSetTextureLUT from the cmd list in add_reset_cmd because it is always set by SPSetOtherMode like other othermodes.
|
If your texture is not set, then you should be able to set the value of the TextureLUT property. This would make it so that the TextureLUT property is properly reverted to normal in the case where a texture is loaded via some function node. This should also fix the bug where unset textures would get defaulted to |
And update other_mode_h_to_dict for the future
jesusyoshi54
requested changes
Jul 28, 2024
jesusyoshi54
approved these changes
Aug 4, 2024
jesusyoshi54
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mode is still automatically set when using CI textures, however the default can now be changed and it hides what's happening under the hood just a bit less, I also removed some code from f3d_bleed, specifically I removed reset_command_dict (unused) and DPSetTextureLUT from the cmd list in add_reset_cmd because it is always set by SPSetOtherMode like other othermodes.
