-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically select correct colorspace #364
Conversation
Maybe an operator popup could work better than just automatically doing it on load? Some people have fast64 installed but have files that are not fast64 related, in which case they shouldn´t have their settings messed with without permission |
You mean like something pops up when you load the scene asking whether you want to change it or not? I'm not sure how to do that or if that's possible. |
See 50a6256 |
Thank you for the implementation @Lilaa3 . I've accepted that but fixed a bug with the conditions checking, and have it only offer to fix if you're loading a scene which has fast64 materials in it (so not when first opening Blender, which was annoying). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just about perfect I think, also that dialog description is way better than the one I suggested aha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
I have some small comments on the implementation
…k_color_management`, simpler message if one Scene, "color space" -> "color management", move settings check to before invoking operator and into helper function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit addressing my review. So this counts as a half-approval since I'm approving my changes 😎
Whenever a material is created or edited, or a scene is loaded, this PR sets the Blender colorspace settings so that preview of vertex colors is accurate (or more accurate than otherwise).