Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically select correct colorspace #364

Merged
merged 5 commits into from
Jun 30, 2024

Conversation

sauraen
Copy link
Contributor

@sauraen sauraen commented Jun 16, 2024

Whenever a material is created or edited, or a scene is loaded, this PR sets the Blender colorspace settings so that preview of vertex colors is accurate (or more accurate than otherwise).

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Jun 16, 2024

Maybe an operator popup could work better than just automatically doing it on load? Some people have fast64 installed but have files that are not fast64 related, in which case they shouldn´t have their settings messed with without permission

@sauraen
Copy link
Contributor Author

sauraen commented Jun 16, 2024

You mean like something pops up when you load the scene asking whether you want to change it or not? I'm not sure how to do that or if that's possible.

@Lilaa3
Copy link
Collaborator

Lilaa3 commented Jun 17, 2024

See 50a6256
Only issue here is that i had to add a quick hack for update nodes to prevent mutiple popups, see if you like this

@sauraen
Copy link
Contributor Author

sauraen commented Jun 19, 2024

Thank you for the implementation @Lilaa3 . I've accepted that but fixed a bug with the conditions checking, and have it only offer to fix if you're loading a scene which has fast64 materials in it (so not when first opening Blender, which was annoying).

@sauraen sauraen requested a review from Lilaa3 June 19, 2024 19:26
Copy link
Collaborator

@Lilaa3 Lilaa3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just about perfect I think, also that dialog description is way better than the one I suggested aha

Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
I have some small comments on the implementation

fast64_internal/f3d/f3d_material.py Outdated Show resolved Hide resolved
fast64_internal/f3d/f3d_material.py Show resolved Hide resolved
fast64_internal/f3d/f3d_material.py Outdated Show resolved Hide resolved
fast64_internal/f3d/f3d_material.py Outdated Show resolved Hide resolved
fast64_internal/f3d/f3d_material.py Outdated Show resolved Hide resolved
…k_color_management`, simpler message if one Scene, "color space" -> "color management", move settings check to before invoking operator and into helper function
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit addressing my review. So this counts as a half-approval since I'm approving my changes 😎

@sauraen sauraen merged commit e2ab268 into Fast-64:main Jun 30, 2024
1 check passed
@sauraen sauraen deleted the FixBlenderColorspace branch June 30, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants