[SM64] Fixed Negative Scales Gfx #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilaa3
approved these changes
May 31, 2024
There was a problem hiding this comment.
The current methods seem very messy to me and normals being wrong still is really bad, but as a temporary fix it is fully valid, should not affect oot at all
test bps.zip
And my branch https://github.com/Lilaa3/HackerSM64/tree/fast-352-test
|
I can fix the normals to match visuals in blender but it wouldn't be "correct" so I decided not to, but I'm not sure on the philosophy of other people. |
jesusyoshi54
added
the
merge soon
Lilaa3
added a commit
to Lilaa3/fast64
that referenced
this pull request
Aug 19, 2024
It is not enough to rely on an object's location and rotation as we need a relative position
Lilaa3
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphics at negative scales would have an extra rotation applied to the geo layout node, which would result in the collision and graphics not aligning. With this, graphics and collision should match in game, and also graphics will match the in blender visualization with the exception of normal direction (which is sort of a blender issue).
Once fixed, close #346