[OoT] Fixed door upgrade

[Yanis42]

It was lacking a simple condition (and an import somehow)

[Dragorn421]

🤔

[Dragorn421]

wouldn't this break existing blends where the fromRoom isn't the room the empty is parented to?
I have such blends

[Yanis42]

should be fixed now

[Dragorn421]

why is the second block under an else now? (elif)

[Dragorn421]

bump

[Yanis42]

this case is most likely impossible but I thought the for loop may not find an object to set to transActorProp.fromRoom, so if this is still None on the block you highlighted it will raise an error (I think I should just assert this idk)

[Dragorn421]

I mean if "dontTransition" in transActorProp: is likely to pass if upgrading a blend
then that means transActorProp.toRoom won't be set based on upgrading from transActorProp["roomIndex"]

[Dragorn421]

btw which previous PR is this a fix for

[Yanis42]

btw which previous PR is this a fix for

PR #243

[Dragorn421]

test blend made using fast64 9637bc4 (before #243): test_door_props.zip

There are three rooms and 5 doors. "Door Actor XY" means "from room X to room Y". the ones with X==Y have "dontTransition" set.

Exporting with 9637bc4 (before #243)

c TransitionActorEntry array:

TransitionActorEntry test_door_props_scene_header00_transitionActors[] = {
    // Wooden Door
    {
        /* Room & Cam Index (Front, Back) */ { 255, 0x00, 1, 0x00 },
        /* Actor ID                       */ ACTOR_EN_DOOR,
        /* Position                       */ { 130, -120, -406 },
        /* Rotation Y                     */ DEG_TO_BINANG(0.000),
        /* Parameters                     */ 0x0000
    },

    // Wooden Door
    {
        /* Room & Cam Index (Front, Back) */ { 1, 0x00, 2, 0x00 },
        /* Actor ID                       */ ACTOR_EN_DOOR,
        /* Position                       */ { -129, -120, -502 },
        /* Rotation Y                     */ DEG_TO_BINANG(180.000),
        /* Parameters                     */ 0x0000
    },

    // Wooden Door
    {
        /* Room & Cam Index (Front, Back) */ { 255, 0x00, 2, 0x00 },
        /* Actor ID                       */ ACTOR_EN_DOOR,
        /* Position                       */ { 119, -120, -596 },
        /* Rotation Y                     */ DEG_TO_BINANG(0.000),
        /* Parameters                     */ 0x0000
    },

    // Wooden Door
    {
        /* Room & Cam Index (Front, Back) */ { 0, 0x00, 1, 0x00 },
        /* Actor ID                       */ ACTOR_EN_DOOR,
        /* Position                       */ { -67, -120, -302 },
        /* Rotation Y                     */ DEG_TO_BINANG(180.000),
        /* Parameters                     */ 0x0000
    },

    // Wooden Door
    {
        /* Room & Cam Index (Front, Back) */ { 255, 0x00, 0, 0x00 },
        /* Actor ID                       */ ACTOR_EN_DOOR,
        /* Position                       */ { 127, -120, -173 },
        /* Rotation Y                     */ DEG_TO_BINANG(0.000),
        /* Parameters                     */ 0x0000
    },
};

opening any door writes

camera: error: illegal camera set (0) !!!!
....change door camera ID -1 (set 1)

in game logs

opening "dontTransition" doors softlocks Link (can't move after link has passed the door)

opening doors between rooms works as expected

Loading blend with 84967dc (current main)

props are basically not upgraded because of missing bpy import lol

Loading blend with 9b17409 (from this PR, #287)

props are mostly upgraded, besides "room to transition to". I believe this is a bug I commented on here #287 (comment)

[Dragorn421]

props are properly upgraded in the previous test blend and the code looks good