[OoT] New Exporter #256
[OoT] New Exporter #256
Conversation
|
I'm sorry about the extra work, but I did state that I thought |
|
I'll try to do the changes soon, I think it's dumb that my own opinions are blocking this cool thing |
There was a problem hiding this comment.
The changes are good so far - there's just a couple spots missed where factory functions should be used to replace storing temporary objects as members. (Also, some other minor code organization issues). After this PR is merged I think the deletion of the old code should happen ASAP - its pretty confusing when trying to review seeing the same class defined twice in the codebase. For future PRs the deletion should be part of the PR.
Refactor decomp edit files + SceneExport
* Deleted scene\exporter, fixed missing code references * Removed unused code from oot_level_writer and oot_level_classes * Removed oot_level_writer, contents moved into appropriate files * Remove unused OOTRoom * Black format
* Deleted scene\exporter, fixed missing code references * Removed unused code from oot_level_writer and oot_level_classes * Removed oot_level_writer, contents moved into appropriate files * Remove unused OOTRoom * Black format * Create shape2.py * Refactor room shape * Remove old files * Remove mesh.py * Remove old comments * Delete old code
* Deleted scene\exporter, fixed missing code references * Removed unused code from oot_level_writer and oot_level_classes * Removed oot_level_writer, contents moved into appropriate files * Remove unused OOTRoom * Black format * Create shape2.py * Refactor room shape * Remove old files * Remove mesh.py * Remove old comments * Delete old code * Add occlusion plane system to new exporter
This is something I wanted to do for a while, it should work properly according to my tests (thanks again to Richie for that)
This relies on dataclasses, I don't think it's the best thing for performances but at least it makes the code easy to follow imo, also it includes functions to get C data so it's kinda 2 in 1, this makes you able to call one of the classes to export a specific type of data, I did that for cutscenes and collisions (collisions required more changes but cutscenes are a one-line change)
Anyway this was fun to make!
Any feedback/suggestions is appreciated! (the diff is huge but this doesn't edit a lot of the original files, most of the diff comes from new files I created)
Extra note: this fix the known issues related to waterbox duplicates, paths and the file(s) being inconsistent at export time, for instance actor entries swapping in the actor list for no reasons
This exporter has everything in the same place (inside the
exporterfolder) instead of having bits of export scattered here and there, I think it makes more sense like this