Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OOT] Use Room objects to set which room to use for entrances #255

Merged
merged 6 commits into from
Dec 26, 2023

Conversation

Yanis42
Copy link
Contributor

@Yanis42 Yanis42 commented Sep 23, 2023

Exactly what PR #243 does but applied to entrances

Small note: because of the current exporter it's still require a room as a parent but I'm working on something that, if it goes well, will remove this requirement

Copy link
Contributor

@sauraen sauraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's let #243 get merged first, cause this has some duplicated code from there.

Copy link
Contributor

@sauraen sauraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this error message clearer, otherwise looks good to me.

fast64_internal/oot/oot_level_writer.py Outdated Show resolved Hide resolved
Copy link
Contributor

@sauraen sauraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sauraen sauraen merged commit 3a2b640 into Fast-64:main Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants