[F3D] Chroma Key F3D source display fix #251
Conversation
| @@ -589,14 +589,15 @@ def ui_chroma(self, material, layout, name, setName, setProp, showCheckBox): | |||
| inputGroup = layout.row() | |||
| prop_input_name = inputGroup.column() | |||
| prop_input = inputGroup.column() | |||
| f3d_mat = material.f3d_mat | |||
There was a problem hiding this comment.
You accidentally removed a new line here. ui_env and ui_image have a new line like that but prim and light don't so its fine really.
|
That's all I can comment on! The ui, exporting and preview all work as intended. |
It is still todo I guess? I'm not sure what the intent of that comment was but I never changed the width logic. |
|
What is not handled in the ui for width exactly? |
|
Width is just a float vector in the UI but in reality it is a signed fixed
point from 0 to 1.
I don't know the extent kure was going to work on this but as it stands it
is kind of unclear what needs to be done.
…On Tue, Dec 26, 2023, 12:19 PM Lilaa3 ***@***.***> wrote:
What is not handled in the ui for width exactly?
—
Reply to this email directly, view it on GitHub
<#251 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTURS42HEZ5FM2YTA3Q5DYLMBLJAVCNFSM6AAAAAA43X2JXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGY3TKMBVHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Got it. I was going to suggest trying to maybe finish the implementation but I'm not sure what's wrong rn, is any value above 1 going outside of the range right now or something |
|
The value stops being effective over one but can be set to much higher
numbers.
…On Tue, Dec 26, 2023, 1:29 PM Lilaa3 ***@***.***> wrote:
Width is just a float vector in the UI but in reality it is a signed fixed
point from 0 to 1. I don't know the extent kure was going to work on this
but as it stands it is kind of unclear what needs to be done.
… <#m_6054643847338230351_>
On Tue, Dec 26, 2023, 12:19 PM Lilaa3 *@*.*> wrote: What is not handled
in the ui for width exactly? — Reply to this email directly, view it on
GitHub <#251 (comment)
<#251 (comment)>>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABTTURS42HEZ5FM2YTA3Q5DYLMBLJAVCNFSM6AAAAAA43X2JXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGY3TKMBVHE
<https://github.com/notifications/unsubscribe-auth/ABTTURS42HEZ5FM2YTA3Q5DYLMBLJAVCNFSM6AAAAAA43X2JXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGY3TKMBVHE>
. You are receiving this because you authored the thread.Message ID: @.*>
Got it. I was going to suggest trying to maybe finish the implementation
but I'm not sure what's wrong rn, is any value above 1 going outside of the
range right now or something
—
Reply to this email directly, view it on GitHub
<#251 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTTURWMDY2QBOYLXE5VS7TYLMJP7AVCNFSM6AAAAAA43X2JXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZG4YDMNZQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Chroma key values were not referencing the correct prop path, and thus were not displaying properly, and also resulted in other props from not displaying.
To see issue, add chroma key scale or center to the combiner, and you will notice missing elements in the sources tab. If you open the console you will also see error messages. These issues are resolved in this PR.