Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OOT] Applied new organisation to oot_level_parser.py #240

Merged
merged 7 commits into from
Aug 12, 2024

Conversation

Yanis42
Copy link
Contributor

@Yanis42 Yanis42 commented Jul 14, 2023

This PR simply moves the different import functions to their proper folders and files

also I moved the removeComments function to the main utility.py file since it can be used for any game

@Yanis42 Yanis42 added this to the v2.2.2 milestone May 31, 2024
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Importing deku tree not broken ✔️

Merging this will cause conflicts in #366 but it's a price I'm willing to (make Yanis) pay

@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label Aug 11, 2024
Copy link
Contributor

@kurethedead kurethedead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should the folder structure for the importer mirror the new exporter? (oot/importer vs oot/scene/importer)

@Dragorn421 Dragorn421 removed the merge soon Will be merged in a few days at most if nothing else comes up label Aug 11, 2024
@Yanis42
Copy link
Contributor Author

Yanis42 commented Aug 12, 2024

I moved it outside the scene folder

@kurethedead kurethedead added the merge soon Will be merged in a few days at most if nothing else comes up label Aug 12, 2024
@kurethedead kurethedead merged commit 672eda3 into Fast-64:main Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants