Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some files had warnings that are easy to fix, so here it is
I'm not able to fix the one from
sm64_f3d_writer.py
and the one fromf3d_parser.py
, though for this one the class seems unusedAbout the change I did in
f3d_gbi.py
, importing the class creates a circular import, so I thought it was better to remove the type hint and put a comment to clarify the type instead, not a great a solution but idk if it can work with the import