Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OoT] Scene-Table parser fix #232

Merged
merged 2 commits into from
Jun 25, 2023
Merged

[OoT] Scene-Table parser fix #232

merged 2 commits into from
Jun 25, 2023

Conversation

HailToDodongo
Copy link
Contributor

Fixes a few issues with the scene-table parser:

  • Handle empty lines (they produce empty DEFINE_SCENE( otherwise)
  • Ignore single-line comments
  • Ignore comments after the first data entry (they would be duplicated on save otherwise)

@HailToDodongo HailToDodongo changed the title OOT: Scene-Table parser fix [OoT] Scene-Table parser fix Jun 22, 2023
Dragorn421
Dragorn421 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ for the changes
I added comments to not have to understand this twice, looks fine to you?

@HailToDodongo
Copy link
Contributor Author

Looks good 👍

@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label Jun 22, 2023
@Dragorn421 Dragorn421 merged commit d97dcd2 into Fast-64:main Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragorn421 Dragorn421 Dragorn421 approved these changes

Assignees
No one assigned
Labels
merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HailToDodongo @Dragorn421