-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import all Mario animations button. #182
Conversation
Added a button to import all of mario´s animations easily and with naming. Commented out an uncessary print at readValueIndex that was slowing down animation import times by about 4 times on my machine.
|
||
marioAnimations = [ | ||
# ( "animation name", "adress" ), | ||
( "0 - Climb up ledge (right leg going up)", 5162640 ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is formatted, so to keep things simple we should just keep it that way
I understand formatting breaks the column layout you have going on, so what about you swap the columns:
marioAnimations = [
# (address, "animation name"),
(5162640, "0 - Climb up ledge (right leg going up)"),
(5165520, "1 - Thrown from painting"),
(5165544, "2 - Blown by wind"),
(this is after formatting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also could you indicate which rom are these addresses for? unless all roms of sm64 are alike
(I'm a OoT enjoyer and there are many ROM versions from where I come 8) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used a script to generate the table so I can fix the formatting easily, the adresses should be consistent across versions I´m pretty sure? Either way you can´t import without an expended rom at the moment, and to get that you need to use the US version.
Fixed formating, swapped segmentData reference for an empty dict as this data is not needed for importing Mario´s animations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can (has) any sm64 enjoyer test(ed) this? 😎
ive tested it, it works. |
Ideally testing is carried out by a different person from the person who made the feature, but since this is simple I'm okay with going ahead like this I'll merge in a few days to give some time for feedback just in case |
I have tested the latest commit and can confirm that it works |
Added a button to import all of mario´s animations easily and with naming.
Commented out an uncessary print at readValueIndex that was slowing down animation import times by about 4 times on my machine.