Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OoT] Imports cleanup #150

Merged
merged 6 commits into from
Oct 15, 2022
Merged

[OoT] Imports cleanup #150

merged 6 commits into from
Oct 15, 2022

Conversation

Yanis42
Copy link
Contributor

@Yanis42 Yanis42 commented Oct 1, 2022

Changes:

  • Removed every from XXX import * from fast64_internal/oot (except the two useless files that gets deleted in [OoT] OoT Object changes & small changes/fixes/removals #95) and other places where things broke
  • Only import classes/functions/variables that are actually required
  • Fixed missing imports where it was needed

Note that I'd love to do that with SM64 files but I don't know a thing about this game so I might break things on accident, though I still fixed some things here and there, same applies for F3D files

Also idk if the oot import is really required inside fast64_internal/__init__.py

@Dragorn421 Dragorn421 added merge soon Will be merged in a few days at most if nothing else comes up codebase Code maintenance/cleanup labels Oct 13, 2022
@Dragorn421 Dragorn421 merged commit ff27879 into Fast-64:main Oct 15, 2022
@Yanis42 Yanis42 deleted the import_cleanup branch December 5, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase Code maintenance/cleanup merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants