bug: Fix grainline arrows #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limit length of grainline to twice the length of a arrowhead.
|
I added a limit on the length of the grainline, which is twice the length of an arrow head (as set in the prefs). This prevents the grainline from collapsing on itself and going in a negative direction.
In the case of a single arrow head there will always be a leader line at least the length of an arrowhead.
|
csett86
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Fixes the grainline arrow heads so they scale with the zoom, and are not fixed at a constant size.
Adds a preference for the arrow head length. It's range is from 25 to 200 pixels.
Refactors the grainlineitem class and related code to clean it up.
This issue closes #1201