Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): simplifies the tray seeding unit tests #290

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

braughtg
Copy link
Contributor

Pull Request Description

Simplifies the tests in lib.submit.unit.cy.js by just checking that the proper values have been passed to the farmosUtil.js library functions used by Tray Seeding's lib.submtForm.


Licensing Certification

FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.

@braughtg braughtg merged commit 1fd4c87 into development Jun 4, 2024
@braughtg braughtg deleted the patch-tray-seeding-tests branch June 4, 2024 14:56
Copy link

github-actions bot commented Jun 6, 2024

🎉 This PR is included in version 1.3.0-development.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jun 10, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-06-10)

### Features

* **comp:** add picklist base component ([#187](#187)) ([b67dc11](b67dc11))
* **dev:** adds the vue force dev plugin to firefox ([#206](#206)) ([ddfa604](ddfa604)), closes [#133](#133)
* **dev:** enables launching dev environment via GitPod ([#236](#236)) ([fbaa5d0](fbaa5d0)), closes [#77](#77) [#4](#4)
* **dev:** improves addEntrypoint.bash script ([#289](#289)) ([ce83da6](ce83da6)), closes [#282](#282)
* **dev:** improves entry point creation and maintainence ([#251](#251)) ([2fe30ff](2fe30ff)), closes [#243](#243) [#189](#189) [#170](#170)
* **docs:** updates the core documentation ([#239](#239)) ([726ddb9](726ddb9)), closes [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#237](#237) [#240](#240)
* **examples:** adds a BedPicker example ([#176](#176)) ([2b13e07](2b13e07)), closes [#175](#175)
* **examples:** adds a DateSelector example for FD2 Examples ([#172](#172)) ([ef81759](ef81759)), closes [#171](#171)
* **fd2:** Add transplanting entry point ([#200](#200)) ([6352e09](6352e09)), closes [#198](#198) [#196](#196)
* **fd2:** submit tray and direct seedings forms as a transaction ([#212](#212)) ([8c082ed](8c082ed))

### Fixes

* builds single css file for each module ([#246](#246)) ([5d34d44](5d34d44)), closes [#202](#202)
* **comp:** adds prop to SoilDisturbance component to hide area field ([d0a9071](d0a9071)), closes [#238](#238)
* **comp:** soil disturbance fix ([#280](#280)) ([77ddeea](77ddeea)), closes [#276](#276)
* **comp:** soil disturbance validity fix ([#278](#278)) ([5543724](5543724)), closes [#276](#276)
* **dev:** fd2-up.linux.bash GID numbering logic ([#162](#162)) ([2b5115e](2b5115e))
* **dev:** moves database file to ~/.fd2/ so it persists in docker volume ([#174](#174)) ([e01f153](e01f153)), closes [#122](#122)
* **dev:** pin in cypress version in package.json ([#257](#257)) ([ae12b8c](ae12b8c))
* **dev:** updates documentation for submit tests in entry point templates ([#291](#291)) ([aefac0a](aefac0a))
* **dev:** uses vite to build e2e tests ([#268](#268)) ([2f6ec86](2f6ec86)), closes [#267](#267)
* **docs:** adds a missing coma to line 27 of README.md ([#253](#253)) ([95d0e5d](95d0e5d))
* **docs:** adds additional documentation for creating an SSH key ([#258](#258)) ([cc97767](cc97767))
* **docs:** corrected typo in codebase.md ([#254](#254)) ([0169dc4](0169dc4))
* **docs:** corrected typos in codebase.md ([#252](#252)) ([1861dfd](1861dfd))
* **examples:** adds control for date prop to DateSelector example ([#173](#173)) ([7ae4f0a](7ae4f0a))
* **examples:** links the BedPicker example in jsDoc and examples page ([#182](#182)) ([25cf07e](25cf07e))
* **examples:** moves example entry point to examples main menu ([#293](#293)) ([6ddc335](6ddc335))
* **examples:** tweaks BedPicker example ([#181](#181)) ([3469c4a](3469c4a))
* **examples:** update index of examples ([#294](#294)) ([e84b023](e84b023)), closes [#259](#259)
* **examples:** uses table for prop and state in DateSelector exammple ([#180](#180)) ([eeefdb7](eeefdb7))
* **fd2:** adds bed awareness to location selection ([#159](#159)) ([c46b5a6](c46b5a6)), closes [#157](#157) [#127](#127) [#160](#160) [#158](#158) [#154](#154) [#156](#156)
* **fd2:** archives tray seeded plant assets when fully transplanted ([#231](#231)) ([7a36c8f](7a36c8f)), closes [#220](#220)
* **fd2:** clears cashed values when terms/assets added to selectors ([#300](#300)) ([f231b6c](f231b6c)), closes [#103](#103)
* **fd2:** enforces asset and log naming conventions ([#235](#235)) ([c09f998](c09f998)), closes [#208](#208)
* **fd2:** removes area quantity from direct seeding form ([#266](#266)) ([f808a5e](f808a5e)), closes [#264](#264)
* **fd2:** removes unnecessary quantity deletes ([#232](#232)) ([5fb743c](5fb743c)), closes [#218](#218)
* **fd2:** updates crop list after each transplanting ([#230](#230)) ([8890076](8890076)), closes [#225](#225)
* **fd2:** updates sticky fields in direct seeding and transplanting forms ([#228](#228)) ([0437225](0437225)), closes [#224](#224) [#226](#226)
* **lib:** adds parent 'Category' asset for all equipment categories ([#303](#303)) ([16eaef7](16eaef7)), closes [#298](#298)
* **lib:** use console.error instead of console.log for errors ([#216](#216)) ([e7968c4](e7968c4)), closes [#210](#210)
* **test:** Direct seeding submission test ([#273](#273)) ([b1669f9](b1669f9)), closes [#269](#269) [#272](#272)
* **test:** fixes the equipment selector test after new db release ([#304](#304)) ([25c331a](25c331a))
* **test:** improves direct_seeding.submission.e2e.cy.js tests ([#269](#269)) ([d7c1c5b](d7c1c5b)), closes [#170](#170)
* **test:** validates form data in submission e2e test ([#270](#270)) ([1695dee](1695dee)), closes [#170](#170) [#170](#170)

### Refactoring

* **fd2:** Generalize transaction ([#214](#214)) ([dbc667c](dbc667c)), closes [#213](#213)
* **fd2:** modifies direct seeding App.vue to match new templates ([#285](#285)) ([c14fcfc](c14fcfc)), closes [#27](#27)
* **fd2:** refactors tray seeding App.vue ([#281](#281)) ([55a6e1d](55a6e1d)), closes [#277](#277)
* **fd2:** updates transplanting to match new templates ([#299](#299)) ([633fac8](633fac8)), closes [#277](#277)
* switches to pgrep for finding servers ([#194](#194)) ([47d13ca](47d13ca))
* **test:** simplifies the direct seeding unit tests ([#292](#292)) ([1bfdc28](1bfdc28))
* **test:** simplifies the tray seeding unit tests ([#290](#290)) ([1fd4c87](1fd4c87))

### Tests

* **comp:** fixes update event test in LocationSelector ([#179](#179)) ([b3bc266](b3bc266))
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant