Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove referer prop #562

Merged
merged 2 commits into from
May 20, 2020
Merged

remove referer prop #562

merged 2 commits into from
May 20, 2020

Conversation

bell-steven
Copy link
Collaborator

@bell-steven bell-steven commented May 19, 2020

This PR reverts #526 and entirely remove support for passing a referer header.
This library is not compatible with restricted API keys, as we don't use the native or JS sdks.

Still in progress: Adding back the origin prop, either in this PR or a follow up.
Edit: It looks like you can add origin directly to query, GoogleReverseGeocodingQuery, GooglePlacesSearchQuery, or GooglePlacesDetailsQuery, depending on which API you use.

This closes #561.

@bell-steven bell-steven linked an issue May 19, 2020 that may be closed by this pull request
3 tasks
@bell-steven bell-steven linked an issue May 19, 2020 that may be closed by this pull request
@bell-steven bell-steven marked this pull request as ready for review May 20, 2020 15:07
@bell-steven bell-steven merged commit 4ec9015 into master May 20, 2020
@bell-steven bell-steven deleted the removeReferrer branch May 20, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referer parameter Update Code when there's no origin it throw an error
1 participant