-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hidden TextInput on Android/Expo #737
Conversation
@davista123 Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove package-lock.json
src/GiftedChat.js
Outdated
@@ -573,6 +586,7 @@ GiftedChat.propTypes = { | |||
loadEarlier: PropTypes.bool, | |||
onLoadEarlier: PropTypes.func, | |||
isLoadingEarlier: PropTypes.bool, | |||
renderKeyboardSpacer: PropTypes.func, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this props if you don't use it?
renderKeyboardSpacer() not used as props. Redundant code.
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 42.91% 42.65% -0.26%
==========================================
Files 20 20
Lines 501 504 +3
Branches 105 106 +1
==========================================
Hits 215 215
- Misses 218 220 +2
- Partials 68 69 +1
Continue to review full report at Codecov.
|
Any update on this one? Having gifted chat do this by default would be great. |
Subscribing. |
Any updates on this @davista123 @xcarpentier ? What still needs to be done? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Any update on this? Currently this library works perfectly on iOS and suffers from this keyboard hiding issue on Android for me. I've tried everything to push the textInput up over the keyboard but nothing has worked. |
try this..
|
I appreciate you, thiss work for me |
This pull request is a fix to issue #578, #435 and #680.
Currently, on android the text input is hidden when the keyboard is focused. I provide a fix by leveraging the react-native-keyboard-spacer library. The fix renders only on android/expo as shown below: