Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite GiftedChat.ts to functional component #2039

Conversation

myckhel
Copy link
Contributor

@myckhel myckhel commented Apr 20, 2021

WIP 👍🏽

#1775

Test

yarn add https://github.com/myckhel/react-native-gifted-chat.git#react-native-gifted-chat-v0.16.5-gitpkg

Pardon me for poor typescript knowledge.

@myckhel myckhel marked this pull request as draft April 20, 2021 23:28
@myckhel myckhel changed the title rewrite GiftedChate.ts to functional component rewrite GiftedChat.ts to functional component Apr 22, 2021
@myckhel myckhel force-pushed the rewrite/functional_component/GiftedChat branch from 030f4b9 to ecd5733 Compare April 26, 2021 20:42
Copy link
Contributor Author

@myckhel myckhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

yarn add https://github.com/myckhel/react-native-gifted-chat.git#react-native-gifted-chat-v0.16.7-gitpkg

Pardon me for poor typescript knowledge

Please @gabrieldonadel @danielmejiadev @Sahith02 @xcarpentier help review and i hope someone can help improve the typescript.

@myckhel myckhel marked this pull request as ready for review April 26, 2021 20:46
@myckhel
Copy link
Contributor Author

myckhel commented Apr 29, 2021

Please @gabrieldonadel @danielmejiadev @Sahith02 @xcarpentier help review very soon.

I am available for changes.

Really want the project to move out from stale status.

@stale
Copy link

stale bot commented Jul 2, 2021

Sorry, but this issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. BTW Thank you for your contributions 😀 !!!

@stale stale bot added wontfix and removed wontfix labels Jul 2, 2021
@Johan-dutoit Johan-dutoit deleted the branch FaridSafi:rewrite/functionnal_component April 14, 2022 13:16
@myckhel myckhel deleted the rewrite/functional_component/GiftedChat branch April 14, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants