Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dm-lab (no tests yet) and dm-control-multiagent #7

Merged
merged 27 commits into from
Dec 5, 2022
Merged

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Nov 3, 2022

No description provided.

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments and it looks like there is a dm_control function that needs updating

shimmy/__init__.py Show resolved Hide resolved
shimmy/dm_lab_compatibility.py Outdated Show resolved Hide resolved
shimmy/dm_lab_compatibility.py Outdated Show resolved Hide resolved
shimmy/dm_lab_compatibility.py Outdated Show resolved Hide resolved
shimmy/dm_lab_compatibility.py Outdated Show resolved Hide resolved
shimmy/utils/dm_env.py Outdated Show resolved Hide resolved
), f"Can't find name for the description: {desc} in spec."

# some observation spaces have a string description, we ignore those for now
if "dtype" in desc:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single if statement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible, we can't do if desc["dtype"] == str if the first statement fails, throwing an error.

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title dmlab wrappers Add dm-lab compatibility environments Nov 15, 2022
@jjshoots jjshoots changed the title Add dm-lab compatibility environments Add dm-lab (no tests yet) and dm-control-multiagent Dec 5, 2022
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 93641f1 into Farama-Foundation:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants