Bump ale-py to v0.8.1 (#37)

Farama-Foundation · Feb 17, 2023 · 6e529b6 · 6e529b6 · vercel · Feb 17, 2023
1 parent 0be00c1
commit 6e529b6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/setup.py b/setup.py
@@ -34,7 +34,7 @@ def get_version():
 
 extras = {
     "gym": ["gym>=0.21"],
-    "atari": ["ale-py~=0.8.0"],
+    "atari": ["ale-py~=0.8.1"],
     # "imageio" should be "gymnasium[mujoco]>=0.26" but there are install conflicts
     "dm-control": ["dm-control>=1.0.10", "imageio", "h5py>=3.7.0"],
     "dm-control-multi-agent": ["dm-control>=1.0.10", "pettingzoo>=1.22"],

diff --git a/shimmy/utils/envs_configs.py b/shimmy/utils/envs_configs.py
@@ -173,17 +173,17 @@
     "surround",
     "tennis",
     "tetris",
-    "tic_tac_toe3_d",
+    "tic_tac_toe_3d",
     "time_pilot",
     "trondead",
     "turmoil",
     "tutankham",
     "up_n_down",
     "venture",
     "video_checkers",
+    "video_chess",
+    "video_cube",
     "video_pinball",
-    "videochess",
-    "videocube",
     "wizard_of_wor",
     "word_zapper",
     "yars_revenge",

diff --git a/tests/test_atari.py b/tests/test_atari.py
@@ -35,15 +35,14 @@ def test_all_atari_roms():
     ],
 )
 def test_atari_envs(env_id):
-    """Tests the atari envs, as there are 1000 possible environment, we only test the Pong variants.
-
-    Known environments that fail this test - ALE/TicTacToe3D-v5, ALE/VideoChess-v5, ALE/Videocube-v5 + ram variants.
-    """
+    """Tests the atari envs, as there are 1000 possible environment, we only test the Pong variants."""
     env = gym.make(env_id)
 
     with warnings.catch_warnings(record=True) as caught_warnings:
         check_env(env.unwrapped)
 
+    env.close()
+
     for warning_message in caught_warnings:
         assert isinstance(warning_message.message, Warning)
         if warning_message.message.args[0] not in CHECK_ENV_IGNORE_WARNINGS: