Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docstrings to the BabyAI envs #302

Merged
merged 17 commits into from
Feb 6, 2023
Merged

Added Docstrings to the BabyAI envs #302

merged 17 commits into from
Feb 6, 2023

Conversation

BolunDai0216
Copy link
Collaborator

Description

Added docstrings to the BabyAI environments.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn this is very impressive, I only have a question on the environment names

minigrid/envs/babyai/goto.py Show resolved Hide resolved
@pseudo-rnd-thoughts
Copy link
Member

To fix the build issues, check that the isinstance(spec.entry_point, str) before the variable

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 88ebc71 into Farama-Foundation:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants