Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add render check to check_environments_match #748

Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Oct 19, 2023

Description

updates check_environments_match to also check for that env.render() is identical

I have being using it to verify the model changes for the mujoco==3.0.0

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as draft October 20, 2023 06:17
@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title check_environments_match add render check add render check to check_environments_match Oct 20, 2023
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good
Will wait for the mujoco 3.0.0 bug fix PR to be finished and merged into this PR before finally merging

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review October 21, 2023 08:33
@Kallinteris-Andreas
Copy link
Collaborator Author

@pseudo-rnd-thoughts re-run CI

@pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts re-run CI

Sorry, I can't rerun the CI, you can push an empty commit to rerun the CI in my experience. https://stackoverflow.com/questions/20138640/pushing-empty-commits-to-remote

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit e5d6921 into Farama-Foundation:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants