Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert existing Gym spec to Gymnasium #506

Closed
wants to merge 16 commits into from
Closed

Convert existing Gym spec to Gymnasium #506

wants to merge 16 commits into from

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Feb 6, 2024

This is a pretty brutal PR, what it does is:

  1. Drops gym support.
  2. Removes the use of 4 different locations for ROMs, that's not really needed anymore since all ROMs will be stored within the Python package on PyPI in future versions.
  3. Moves the ROMs directly into the roms folder.
  4. Streamlines the Python files to be less scattered.

To-do:

  • Fix tests, I'm not sure what the exact way to do this is and it depends on what we want to support
  • Better pre-commits

@jjshoots jjshoots marked this pull request as draft February 6, 2024 00:54
@jjshoots jjshoots closed this by deleting the head repository Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant