Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parametrisation examples #45

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

ikorotkin
Copy link
Collaborator

Added 5 parametrisation examples:

  • nmc_pouch_cell_BPX.json from About:Energy open-source release (DFN parametrisation)
  • lfp_18650_cell_BPX.json from About:Energy open-source release (DFN parametrisation)
  • Example of blended electrode definition with two particle sizes but equivalent chemistry
  • Example of user-defined 0th-order hysteresis for graphite-Si blend in negative electrode
  • SPM parametrisation example based on nmc_pouch_cell_BPX.json

From the email chain:

  • For blended electrodes and SPM(e): define the equations that are expected to be obeyed, see issue Validation based on models #29
  • Should we be more strict in how the phases are labelled (e.g., make them "Primary", "Secondary")?

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@679e153). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #45   +/-   ##
==========================================
  Coverage           ?   97.07%           
==========================================
  Files              ?        9           
  Lines              ?      308           
  Branches           ?        0           
==========================================
  Hits               ?      299           
  Misses             ?        9           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ejfdickinson
Copy link
Collaborator

@ikorotkin @rtimms

I disagree with the suggestion to restrict what BPX users can call the components of a blended electrode for the following reasons:

  • Free naming supports a human-readable standard. People may use the functionality for different reasons – different chemistries, different particle sizes, or as ways to implement more complex models in conjunction with user-defined parameters.
  • “Primary” and “secondary” particle have a specific physical meaning in the sense of an agglomerate (in which they actually refer to the same material, but grouped at different scales). Locking that specific nomenclature would be locking something ambiguous / wrong.
  • It doesn't solve the problem of inequivalent BPX files encoding the same model, because you can always permute the parallel electrode contributions. We would want a more general comparison / diff tool for BPX, as well as perhaps a tool to reduce a BPX file to a "canonical" limiting reporting standard, in which user-specific naming could be stripped.

@rtimms rtimms merged commit cd00a67 into FaradayInstitution:develop Oct 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants