Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maximum concentration in positive electrode in test file #30

Closed
smitasahu2 opened this issue May 26, 2023 · 1 comment
Closed

Fix maximum concentration in positive electrode in test file #30

smitasahu2 opened this issue May 26, 2023 · 1 comment

Comments

@smitasahu2
Copy link

In BPX/tests/test_utilities.py there is a typo
Positive electrode Maximum concentration [mol.m-3]": 631040 but it should be 63104.0
@ikorotkin ikorotkin mentioned this issue Jun 16, 2023
Merged
ikorotkin added a commit to ikorotkin/BPX that referenced this issue Jun 16, 2023
@ikorotkin
Fixed maximum concentration in test_schema.py according to issue Fara…
3f83150 
…dayInstitution#30
@rtimms
Copy link
Collaborator

rtimms commented Jun 16, 2023

Fixed by #31

@rtimms rtimms closed this as completed Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtimms @smitasahu2