Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsSignatureHandler now overrides the synchronous Send() method in .NET 5. #479

Merged

Conversation

Timovzl
Copy link
Contributor

@Timovzl Timovzl commented Aug 30, 2021

fix: Synchronous HttpClient.Send().

AwsSignatureHandler now overrides the synchronous Send() method in .NET 5.

Closes #478.

I did not have time to conform to the contribution guidelines to the letter. Feel free to use this PR as you see fit. If you prefer to reject it and copy relevant changes to your own PR, I'm all for it.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Checklist

  • I have squashed my commits into a single one with a message that aligns with the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@FantasticFiasco
Copy link
Owner

I think I'm done with the review. Do you have anything else to add or mention?

@Timovzl
Copy link
Contributor Author

Timovzl commented Sep 7, 2021

I think I'm done with the review. Do you have anything else to add or mention?

Great work, nice improvements. I've added one nitpick, but I have no further additions. I appreciate you picking this up so fast.

@FantasticFiasco FantasticFiasco merged commit 8d4a743 into FantasticFiasco:master Sep 7, 2021
@Timovzl Timovzl deleted the fix/OverrideSynchronousSend branch September 8, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpClient.Send (synchronous API) is not intercepted
2 participants