-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AwsSignatureHandler now overrides the synchronous Send() method in .NET 5. #479
Merged
FantasticFiasco
merged 19 commits into
FantasticFiasco:master
from
Timovzl:fix/OverrideSynchronousSend
Sep 7, 2021
Merged
AwsSignatureHandler now overrides the synchronous Send() method in .NET 5. #479
FantasticFiasco
merged 19 commits into
FantasticFiasco:master
from
Timovzl:fix/OverrideSynchronousSend
Sep 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timovzl
commented
Aug 31, 2021
FantasticFiasco
approved these changes
Sep 6, 2021
I think I'm done with the review. Do you have anything else to add or mention? |
Timovzl
commented
Sep 7, 2021
Great work, nice improvements. I've added one nitpick, but I have no further additions. I appreciate you picking this up so fast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Synchronous HttpClient.Send().
AwsSignatureHandler now overrides the synchronous Send() method in .NET 5.
Closes #478.
I did not have time to conform to the contribution guidelines to the letter. Feel free to use this PR as you see fit. If you prefer to reject it and copy relevant changes to your own PR, I'm all for it.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Checklist