Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use space character as the separator for user-agent header instead of comma #1156

Conversation

mungojam
Copy link
Contributor

Description

This fixes a signing error that occurs with multiple user agent parts, e.g. Mozilla/5.0 Gecko/geckotrail

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@FantasticFiasco FantasticFiasco self-assigned this Sep 17, 2024
@FantasticFiasco
Copy link
Owner

These changes looks awesome, added tests and everything!

I'll merge the pr right now, and then tomorrow I'll include it in a new release. Thank you so much for the contribution!

@FantasticFiasco FantasticFiasco merged commit 85b6d17 into FantasticFiasco:master Sep 17, 2024
@mungojam
Copy link
Contributor Author

Thanks for the kind words 🙂, always happy to contribute to such a useful and unique library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-part user agent is joined incorrectly leading to AWS signature failures
2 participants