Skip to content

Commit

Permalink
Release v1.9.3 (#108)
Browse files Browse the repository at this point in the history
* Add changelog

* Prettier format

* increase test timeout

* Adding true vim shortcuts (j and k)

* Mention additoinal key shortcuts in readme

* Bump version in manifest

* Increate wait time for interaction in E2E tests

---------

Co-authored-by: Simon Heimler <mail@simon-heimler.de>
  • Loading branch information
Fannon and Simon Heimler authored Oct 14, 2023
1 parent 6d46ff2 commit 7804b7f
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 13 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## [unreleased]

## [v1.9.3]

- **NEW**: Search results can now also be navigated Emacs or Vim style (feature request [#106](https://github.com/Fannon/search-bookmarks-history-and-tabs/issues/106))
- `Ctrl+N` and `Ctrl+J` for downward navigation
- `Ctrl+P` and `Ctrl+K` for upward navigation
- **FIXED**: If `debug: true` has been set, the extension crashed on a performance measurement analysis

## [v1.9.1]
Expand Down
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ This extension is built to respect your privacy:

- **Search Strategies**: Switch between precise and fuzzy approach by clicking on the FUZZY or PRECISE button in the search bar (top right).
- **Keyboard Shortcut**: Trigger the extension via keyboard.
- The default is `CTRL` + `Shift` + `.`, but you can customize this.
- The default is `CTRL` + `Shift` + `.`, but you can customize this (I personally use `Ctrl+J`).
- **Open selected results**: By default, the extension will open the selected result in a new active tab, or switch to an existing tab with the target url.
- Hold `Shift` or `Alt` to open the result in the current tab
- Hold `Ctrl` to open the result without closing the popup.
Expand All @@ -67,6 +67,9 @@ This extension is built to respect your privacy:
- The option `customSearchEngines` allows you to define your own search mode aliases
- Default: Start your query with `g ` (including space): Do a Google search.
- Default: Start your query with `d ` (including space): Do a dict.cc search.
- **Emacs / Vim Navigation**:
- `Ctrl+N` and `Ctrl+J` to navigate search results up
- `Ctrl+P` and `Ctrl+K` to navigate search results down
- **Special Browser Pages**: You can add special browser pages to your bookmarks, like `chrome://downloads`.
- **Custom Scores**: Add custom bonus scores by putting ` +<whole number>` to your bookmark title (before tags)
- Examples: `Bookmark Title +20` or `Another Bookmark +10 #tag1 #tag2`
Expand Down
7 changes: 1 addition & 6 deletions cypress.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,8 @@ module.exports = defineConfig({
viewportWidth: 500,
viewportHeight: 600,
video: false,
defaultCommandTimeout: 12000, // E2E Edge test is slow in CI/CD
defaultCommandTimeout: 16000, // E2E Edge test is slow in CI/CD
e2e: {
// We've imported your old cypress plugins here.
// You may want to clean this up later by importing these.
setupNodeEvents(on, config) {
return require('./cypress/plugins/index.js')(on, config)
},
baseUrl: 'http://localhost:8080/popup',
},
})
Binary file added cypress/downloads/downloads.htm
Binary file not shown.
4 changes: 2 additions & 2 deletions cypress/e2e/search.cy.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const interactionTime = 100
const initTime = 400
const interactionTime = 300
const initTime = 500

describe('Search View', () => {
beforeEach(() => {
Expand Down
2 changes: 1 addition & 1 deletion manifest.firefox.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
"homepage_url": "https://github.com/Fannon/search-bookmarks-history-and-tabs",
"author": "Simon Heimler",
"version": "1.9.2",
"version": "1.9.3",
"manifest_version": 2,
"applications": {
"gecko": {
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "Browser extension to (fuzzy) search and navigate bookmarks, history and open tabs.",
"homepage_url": "https://github.com/Fannon/search-bookmarks-history-and-tabs",
"author": "Simon Heimler",
"version": "1.9.2",
"version": "1.9.3",
"manifest_version": 3,
"permissions": ["tabs", "bookmarks", "history", "storage"],
"action": {
Expand Down
4 changes: 2 additions & 2 deletions popup/js/view/searchView.js
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,8 @@ export function renderSearchResults(result) {
*/
export function navigationKeyListener(event) {
// Navigation via arrows or via Vim style
const up = event.key === 'ArrowUp' || (event.ctrlKey && event.key === 'p')
const down = event.key === 'ArrowDown' || (event.ctrlKey && event.key === 'n')
const up = event.key === 'ArrowUp' || (event.ctrlKey && event.key === 'p') || (event.ctrlKey && event.key === 'k')
const down = event.key === 'ArrowDown' || (event.ctrlKey && event.key === 'n') || (event.ctrlKey && event.key === 'j')

if (up && ext.dom.searchInput.value && ext.model.currentItem == 0) {
event.preventDefault()
Expand Down

0 comments on commit 7804b7f

Please sign in to comment.