-
Notifications
You must be signed in to change notification settings - Fork 6
Add 'cosine' as supported similarity function #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add 'cosine' as supported similarity function
WalkthroughThe documentation for vector index creation has been updated to specify that both 'euclidean' and 'cosine' similarity functions are supported. This replaces the previous documentation, which only mentioned 'euclidean'. No changes were made to code or exported/public entities; the update is limited to clarifying the supported options in the documentation. Changes
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cypher/indexing.md (1)
252-252
: Improve conciseness and clarity in listing supported functions.The phrase “At the moment the only supported similarity functions are 'euclidean' or 'cosine'.” can be made more concise and accurate by using an adverb and the conjunction “and”:
- At the moment the only supported similarity functions are 'euclidean' or 'cosine'. + Currently, the only supported similarity functions are 'euclidean' and 'cosine'.🧰 Tools
🪛 LanguageTool
[style] ~252-~252: For conciseness, consider replacing this expression with an adverb.
Context: ...d similarity function must be provided. At the moment the only supported similarity functions...(AT_THE_MOMENT)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cypher/indexing.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
cypher/indexing.md
[style] ~252-~252: For conciseness, consider replacing this expression with an adverb.
Context: ...d similarity function must be provided. At the moment the only supported similarity functions...
(AT_THE_MOMENT)
Add 'cosine' as supported similarity function
Summary by CodeRabbit