Prevent direct access and triggered deprecation warning for "word" me… #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the safeEmailDomain also needs (), I got a lot of warnings about that to. Couldn't figure where it came from. |
bram-pkg
requested changes
Apr 15, 2021
|
|
||
| $submit = $element->ownerDocument->createElement(static::INPUT_TAG); | ||
| $submit->setAttribute('type', 'submit'); | ||
| $submit->setAttribute('value', $this->generator->word); | ||
| $submit->setAttribute('value', $this->generator->word()); | ||
|
|
||
| $submit = $element->ownerDocument->createElement(static::FORM_TAG); | ||
| $submit->setAttribute('action', $this->generator->safeEmailDomain); |
There was a problem hiding this comment.
Add method call here too, on safeEmailDomain?
There was a problem hiding this comment.
Yeah will review the core methods quickly to see what else we hit
bram-pkg
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Deprecation warnings are thrown from core methods while direct accessing properties which is not allowed anymore since 1.14
Author's checklist
Summary of changes
The internal methods now call the function instead of accessing the properties directly.
Review checklist