[pull] main from chromium:main #124
Merged
Commits on Dec 16, 2021
-
Reland "input: Add keyboard details, top row, to input diagnostics"
This is a reland of de046eb Fixing browser test that broke in original, without symptoms on local or tryjob runs; the fix in fake_data.js is directly equivalent to the change in input_list_test.js. Original change's description: > input: Add keyboard details, top row, to input diagnostics > > Additions to input diagnostics backend, increasing detail > for keyboards, particularly information about the top row > key assignments, plus tweaks to number-pads. > > Bug: 1207678 > Test: ./out/Debug/ash_webui_unittests --gtest_filter=*InputDataProviderTest* > Test: ./out/Debug/browser_tests --gtest_filter='DiagnosticsAppWithInput.*' > Test: tested with subsequent patches on Jinlon, for internal and external keyboards > Change-Id: I88d4e1051227d3226d51f88a58c0fc903a6d4975 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299112 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Harry Cutts <hcutts@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Kenneth Albanowski <kenalba@google.com> > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Commit-Queue: Kenneth Albanowski <kenalba@google.com> > Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> > Cr-Commit-Position: refs/heads/main@{#952129} Bug: 1207678 Test: ./out/Debug/browser_tests --gtest_filter='DiagnosticsAppWithInput.*' Change-Id: I9ff398a59e38cb96b47476cd26695387421134f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344386 Reviewed-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kenneth Albanowski <kenalba@google.com> Cr-Commit-Position: refs/heads/main@{#952533}
-
Let AutocompleteEditTextTest know about a bug in EditText
It turns out that EditableInputConnection, which is used internally by EditText, has had an off-by-one bug that fails to return "false" as requested in the API document when its internal batch edit count becomes 0 [1]. Although the bug is finally fixed in the ToT of Android OS [2] and expected to be shipped in a future version, it takes time for the fix to be delivered to our test environment, which is Robolectric for EditableInputConnection. Even worth, when the fix is delivered some tests would start failing because they assume the broken OS behavior. In order to avoid sudden test failures in the future, this CL aims to abstract out such an OS bug from our high level test expectations by dynamically checking whether such a bug still exists or not at runtime. In this way, each test can focus on its own business logic without worrying about the broken OS behavior. A bonus is that we can even test those two different OS behaviors in the future for free just by specifying multiple SDK versions to the test runner [3]. Other than that, there should be no change in the high level expectations of those tests. [1]: https://issuetracker.google.com/issues/209958658 [2]: https://android-review.googlesource.com/c/platform/frameworks/base/+/1923058 [3]: http://robolectric.org/configuring/ Bug: 209008342 Test: ninja -C out/Default chrome_junit_tests && out/Default/bin/run_chrome_junit_tests -f *AutocompleteEditTextTest.* Change-Id: I23367c39af867fc5251e403f2e17ba324d65dc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330592 Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Reviewed-by: Tomasz Wiszkowski <ender@google.com> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/main@{#952535}
-
[GTK] Update frame decorations for GTK4
In GTK4, the "decoration" node is removed and the frame shadow is drawn directly on the window. Additionally, the window contents are clipped by the window shape instead of being drawn over the window. This means the corner radius computation must also be adjusted. R=sky Bug: None Change-Id: I5aa97434b66bbd9c04d1b22c3ba958d3d79e5451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340172 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#952536}
-
[Sheriff] Disable DevToolsProtocolTest.NavigationPreservesMessages
Disable test due to flakiness. Seems like result_ids order is flipped Bug: 1280531 Change-Id: I60d9b192215995d77263fcf6b17af4e6621646b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345631 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952537}
-
[Dr-Dc] Thread safe vulkan Queue.
1. Allow thread safe access to a vulkan queue from gpu main thread and drdc thread by using locks around all queue access. This includes using locks in all vkQueue* api calls. 2. Use a map to generate lock per queue. 3. Update gpu/vulkan/generate_bindings.py to autogenerate relevant code. Bug: 1262385 Change-Id: Icd730759d863522981fd14ea6e39fadb67c70365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339655 Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/main@{#952538}
-
[fuchsia] Add Flatland to Fuchsia watchlist
Add the new flatland ozone directory to ozone_fuchsia, which was renamed from ozone_scenic to represent both Flatland and Scenic. Change-Id: I25d8a0d6fdcf80dc933b3494d483a8eaacb5c814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339169 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952539}
-
overflow-clip-margin: Make sure we can inherit from any parent.
This patch ensures that we can inherit the value from any parent, even if the value itself has no effect on the parent. R=ikilpatrick@chromium.org, chrishtr@chromium.org Change-Id: I26586956884a1b8b922e9fce75ee4ad408cb4798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335076 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#952542}
-
Use abstract interfaces in CORB unit tests.
This CL tweaks the ResponseAnalyzerTest::RunAnalyzerOnScenario method, so that it takes an abstract ResponseAnalyzer interface as input (instead of taking a concrete CorbResponseAnalyzer before this CL). This CL helps with adding ORB test coverage in follow-up CLs. This CL removes CorbResponseAnalyzer::canonical_mime_type accessor. Note that the canonical MIME type is already covered by the following tests: - The CrossOriginReadBlockingTest.GetCanonicalMimeType unit test in //services/network/public/cpp/corb/corb_impl_unittest.cc - UMA-based coverage via - The ResponseAnalyzerTest.ResponseBlocking unit test in //services/network/public/cpp/corb/corb_impl_unittest.cc - The InspectHistograms helper function used by the browser tests from //content/.../cross_site_document_blocking_browsertest.cc Bug: 1178928 Change-Id: I2c0bbeb7bb6258318d852e07a28c1550b7bf89dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334957 Reviewed-by: Charles Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#952543} -
[Sheriff] Disable BackForwardCacheBrowserTest.ShortVibrationSequenceS…
…topsAfterEnteringCache on Mac Bug: 1280741 Change-Id: I8411e4f48d332e179023afa068503f1c3aa04700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344011 Owners-Override: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952546}
-
Remove unused directories from distributed_point_functions library
Only the dpf/ top-level directory contains code that is used. Removing the unused directories will avoid presubmit errors from unused code that #includes files not allowed by the DEPS. Bug: 1227772 Change-Id: I830db6c06e89f7b9ce32f2587bc26a5e087b9db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337416 Reviewed-by: Nan Lin <linnan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Auto-Submit: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/main@{#952547}
-
Remove report from SentReport and rename to SendResult
Report can just be bound to the callback, and this would make it easier for reuse by aggregate reporting. Change-Id: Iac3939e8a20e1bf3fdefd7864e59d90ecdef677c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341346 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#952548}
-
[GridFragmentation] Fix crash with indefinite forced breaks.
Previously within ShiftBreakpointIntoNextFragmentainer we'd always assume the fragmentainer_space was definite. Inside the initial column balancing pass this is incorrect. For this case we set the fragmentainer_space to the row breakpoint such that we'll position the items in the correct fragmentainer. Added test grid-item-fragmentation-039 which would trigger the crash. However this doesn't solve the issue as we are reporting an incorrect block-size. Bug: 614667 Change-Id: I155d744f92744e1196c70fb17179e3e2324fe63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343453 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#952551}
-
[block-in-inline] Rebaseline LayoutInlineTest.AbsoluteBoundingBoxRect…
…HandlingEmptyInlineVerticalRL The same rebaseline as r952148 crrev.com/c/3341436 but for the `vertical-rl` variation. Bug: 716930 Change-Id: Ia2fdefb8c06d8410e0718b450a50b25da489ef00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343697 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#952553}
-
Media Foundation Frame Server Mode Part 3: Media Foundation Texture Pool
Add the component that will allocate and manage the D3D11Texture2D objects that are used by the Media Foundation Media Engine and provided to Chromium. Bug: 1258887 Issue: 1258887 Change-Id: I609b13d029384e6fba709a5cbb210ec8fc9ca721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3290069 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952554}
-
PWA: move permission_item and its dependencies to cr_components
This moves permission_item from chromeos/os_apps_page/app_management to cr_components/webapps so that it can be re-used by web app settings page on Windows/Mac/Linux. Functional changes: - Removed store_client dependency for permission_item, passing app directly via polymer data binding. - Removed metrics_recorder dependency, only use util.js to recordAppManagementUserAction. Pure move: - permission_item - util.js excluding openAppDetailPage,openMainPage that rely on Router. - permission_constants - permission_util - constants - toggle_row - shared_tyle - shared_vars - app_management.mojom Change-Id: If54396080b4a7d2df248f0857a1d5a9ae2fe87c9 Bug: 1255194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311618 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/main@{#952555}
-
Remove VLOGs for fetch keepalive + shutdown
I added some VLOGs for crbug.com/1161996. As the investigation is done, let's remove the VLOGs and/or turn the VLOGs to DVLOGs. Bug: 1161996 Change-Id: I23a879536677c2f4313bfe2dfb01d188f0f5247d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344528 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#952560}
-
1) Mark navigations via Page.navigate from Chrome extensions as renderer-initiated. 2) Send DidAccessInitialDocument once CDP client attaches to avoid spoofing of browser-initiated failed navigation. A renderer-initiated pending URL is typically shown in the address bar above the initial about:blank page, until someone tries to modify the about:blank page, at which point it becomes a URL spoof risk. Since the DevTools protocol can be used to modify the initial about:blank page, its use should signal that the pending URL isn't safe to display. Bug: 1192417 Change-Id: I585b69e59ed44fefb01d4216ead1c82c27c976af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3310854 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Charles Reis <creis@chromium.org> Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#952562}
-
[LR] Add the tears of joy reaction
Adds the GIF asset and PNG thumbnail for the Tears of Joy reaction for the Lightweight Reactions feature. Also changes the accessibility string of the existing Heart reaction to "Beating Heart", in accordance with UXW guidance. Bug: 1279915 Change-Id: Ifc7e3e6901e612f6e5e384a62718fa7ed82f45d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345441 Reviewed-by: Sophey Dong <sophey@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/main@{#952571}
-
Record UKM for share clicks on mobile
The xml description and approval already exists. This code was removed during refactoring by mistake. Start recording this metric again. Bug: 910374 Change-Id: I44b1d5035b054b1728c7efe1225915541cc843bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345550 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/main@{#952573}
-
webcodecs: Groundwork for software AV1 encoder based on libaom
This CL introduces Av1VideoEncoder - an implementation of media::VideoEncoder interface that uses libaom to encode AV1 video format. libaom API is similar to libvpx API, but it is sufficiently different to make it impractical to generalize VpxVideoEncoder. Av1VideoEncoder is also plugged into blink::VideoEncoder, so AV1 encoding can be tested with WebCodecsAv1Encoding feature flag. Bug: 1208280 Change-Id: Ic5d6e0ae2041ec1cbc60a21746c4c390806f5cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3314358 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Johann Koenig <johannkoenig@google.com> Reviewed-by: James Zern <jzern@google.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#952576}
-
bluetooth: Fix the test that returns before the test promise resolved
This is address the flaky issue of bluetooth/requestDevice/blocklisted-service-in-filter.https.window.js introduced in crrev.com/c/3322017, which later on got reverted in crrev.com/c/3341457. Bug: 994756, 1280218 Change-Id: I0756c7e55cb528b915d8651b2310aa6db1a9fa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342745 Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Jack Hsieh <chengweih@chromium.org> Cr-Commit-Position: refs/heads/main@{#952577}
-
WebUI: Migrate shared custom_element.js to TypeScript.
All clients of that file are already migrated to TS. By migrating to TS, the signature of $() and $all() methods is improved to leverage generics and propagate types to the underlying querySelector/querySelectorAll methods. As part of this change discovered that the DownloadShelf UI was opting out of some strict TS checks (by setting "strictNullChecks": false). Removed the flag and fixed violations. Bug: 1189595 Change-Id: I681d2506f6e6e9d6fb5e6bb46cf0b225ec42b7aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344388 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#952580}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.