[pull] main from chromium:main #123

The context menu options on apps grid view and app list item for app reordering was previously implemented for testing. The main difference made in this cl was to (1) Remove or comment out the reverse alphabetical sorting options and as we currently don't have a plan to put the reverse alphabetical sorting into production. (2) Add icons and use i18n interpreted strings for options. No fundamental logic change except context menu structure change. Bug: 1269386, 1276230 Change-Id: I0362581e69bd320490555a2ee1044f7983ab8ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339912 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Wen-Chien Wang <wcwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#952434}

Change-Id: I552a7f6482e1d01980f6dcd0567ef23afab6deaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338979 Reviewed-by: Kyle Charbonneau <kylechar@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kevin Haslett <khaslett@chromium.org> Cr-Commit-Position: refs/heads/main@{#952435}

This CL: * Revert https://crrev.com/c/3276194 * Update passwords settings header See: https://drive.google.com/file/d/1UVnrDCaBn11dMW4-0yh5H_tmIpto6O7a/view?usp=sharing&resourcekey=0-z8PSgEKi1RZScsXpFHLeEg Learn more video: https://drive.google.com/file/d/1dTs7B85VphyL2JUdI1-x7o47eeo1jXOF/view?usp=sharing&resourcekey=0-seXobAxwW5AMWbMe0KX--w Fixed: 1280336 Change-Id: I9de576e10340a366029a42d52cf83b3d406b27ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341530 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Aliona Dangla <alionadangla@google.com> Cr-Commit-Position: refs/heads/main@{#952436}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202112160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/5GaoHsS9Sb6U1WEQwNSowrgNf8r6rvc0he_rf8kNgSQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/200896691 Tbr: help-app@grotations.appspotmail.com Change-Id: Icc59ba79b9561f1745c50f0fe016f875cbc81e49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345182 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952437}

This pulls in the following changes: https://github.com/google/flatbuffers/compare/4f7f6dc301f5ffb9765b055d48324dc7629abd5a..b8aaccee8248059b2af032cca0eb1d2ddbdb6cdc Bug: 1270005 Change-Id: I614a2932e64094b2c1e216c3668fa5ae174a7b6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330460 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#952438}

When a property model binds to a view, it will only bind set properties when the change processor is created. In the chip list, the 'selected' property is not set initially, leaving the view's selected state as false while not explicitly bound. This causes issues in the recycler view where the ChipViews are reused -- tapping a chip will set the state, and if the other models haven't been explicitly set, that property is never bound which leaves it in the previous model's state. This patch fixes the issue by explicitly setting the model's property to false when created. Bug: 1276912 Change-Id: I623328208718dacc4fc30fda45c6cf35a4964edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345197 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#952439}

The first is_win condition does not need to be nested. The second is_win condition redundant and the result of changes in https://codereview.chromium.org/2308813002/diff/910001/remoting/BUILD.gn Change-Id: Ia46b575437241a60d8f1d908a8b55c43016b64c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343411 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952440}

Using wpt-import in Chromium 37a40c5. With Chromium commits locally applied on WPT: 6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies" 7cd9af9 "Always assume that non-auto 'columns' might create a multicol." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/css-ui NOAUTOREVERT=true No-Export: true Change-Id: I0df73bf4ff885241d37a2c004dcd84fe143f6336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345123 Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#952441}

…log. Test: manual Fixed: 1279910 Change-Id: Ic73d2824863a1d2d93857bd780f637ef272e4f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343447 Reviewed-by: Jeremy Chinsen <chinsenj@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/main@{#952442}

This enables the capture of the AMP subframe served by gnews Bug: 1257313 Change-Id: Ie09045242d38de783a7a8c08def763e0deb016ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342149 Reviewed-by: Travis Skare <skare@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/main@{#952443}

This CL is technically no-op, but a preparation for an upcoming CL that will rename those metrics. Here is the output of the verification command: python3 ./tools/metrics/histograms/print_histogram_names.py --diff origin/main 0 histograms added: 0 histograms removed: 0 histograms obsoleted: Bug: 1259121 Change-Id: I625f345f5b954d54d996a58fa092a99ef185c93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344629 Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/main@{#952444}

The current layout was set to VK_IMAGE_LAYOUT_UNDEFINED and never set anywhere. Remove it to not mislead people into thinking that it tracks the last layout of the image. Bug: chromium:1279419 Change-Id: Ia925e7f118677809509dad30c64ed2a424d49e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340716 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#952445}

When uploading chartjson format results, the url request complains for ValueError: Invalid header value. Removing the '\n' at the end of the auth token should resolve the issue. Change-Id: I52708e9232d51781107fd98421bb04e2459f638f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344726 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/main@{#952446}

NOTE TO SHERIFFS: This will break weblayer skew tests. A followup change will fix the expectations for the skew tests once we know which ones have broken (figuring this out in advance is too difficult at the moment). Initially written by peconn@chromium.org. I just fixed the weblayer tests as this change is urgent and Peter's OOO. This change makes WebLayer behave in the same was as Custom Tabs when considering whether a navigation should trigger an external app launch. When considering whether to launch an Android app as the result of a user navigation, Custom Tabs use the following logic: - If the client app can handle the link, launch that - else, if there is an app that can handle that link by default (without showing the Android disambiguation dialog), launch that - else, if the browser can handle the link, stay in the browser - else, show the disambiguation dialog This differs from standard Chrome logic in that if we were going to show the Android disambiguation prompt for a link that the browser could handle, we just keep the user in the browser instead. The current WebLayer behavior is: - If there are apps on the device that can handle the link: - if there is a default, launch that - else, show the disambiguation prompt With this change, the WebLayer behavior will be in line with the Custom Tabs behavior (bearing in mind that WebLayer doesn't have a "client app"): - If there is a default handler for the link, launch that, - else, if the browser can handle the link, stay in the browser. - else, show the disambiguation dialog So in summary, WebLayer will try to avoid showing the Android disambiguation prompt by keeping the user in the browser if possible. Bug: 1251722 Change-Id: I4bf350eb58ce4a92fee367fe9c350919b9aa862f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342807 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#952447}

Delay the audio device detection in Assistant opt-in flow to avoid possible timing issues. Before we detect audio device on OOBE page load, now it is attached to some other later events (after Assistant ready). Bug: b/210812469 Change-Id: Ibfeb99273bcaf9e84adc4c3faa9286010e92fb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343282 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/main@{#952448}

…-party iframes This hooks the new third-party delegation aware accept-ch header parser into the named meta tag decoder and adds associated browser tests. This CL is a part of a series: (1) Add Feature (2) Add 'name' identical to 'http-equiv' version (3) Lock 'name' version to pre-execution text state (4) Add third-party delegation parser (5) Add ability to modify PermissionsPolicy (6) Add 'name' support for third-party subresources (7) Add ability to extract raw AllowLists (8) Add 'name' support for third-party iframes (9) Enable by default (10) Add webtests Bug: 1219359 Change-Id: Idb4dce7652995fa00b473fa90b8ddf401b2574da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321388 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Auto-Submit: Ari Chivukula <arichiv@chromium.org> Commit-Queue: Ari Chivukula <arichiv@chromium.org> Cr-Commit-Position: refs/heads/main@{#952449}

Use a 3-value enum instead of 2 bools. This is in preparation for adding WASM support, which has different requirements (being optional); and this representation will be usable for both, making adjusting the state progression logic easier. Bug: 1275638 Change-Id: Iabbc8cee5194d4b06a37b5717752b4353cc15564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345301 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/main@{#952450}

Replace ScanResult enum with FingerprintMessage protobuf in FakeBiodClient class. This will allow tests to send Error enum. BUG=b:184843581 b:197959527 TEST=autoninja -C out/Debug_chromeos/ browser_tests ./out/Debug_chromeos/browser_tests Files chrome/browser/ash/login/lock/fingerprint_unlock_browsertest.cc chrome/browser/ash/login/lock/screen_locker_browsertest.cc Change-Id: I214449772e59a92fbf7f1420b578d0584a5b6ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304061 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com> Cr-Commit-Position: refs/heads/main@{#952451}

Create an experimental feature to enable sending sample pings of Protego allowlist domains to Safe Browsing. Bug: 1275242 Change-Id: I39fc92c6fcd052d147fd2e3158511e08fb78c56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338978 Auto-Submit: Zack Han <zackhan@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952452}

This change ensures that breadcrumbs are appended to crash reports only when UMA consent has been given (and the experiment is enabled). This is required by privacy because breadcrumbs includes data from UMA (specifically, a subset of tools/metrics/actions/actions.xml). This CL affects breadcrumbs on desktop, which will begin rolling out on Finch shortly. A subsequent CL will do the same for iOS, which is already active on 1% of Stable. Bug: 1163762 Change-Id: Idd3a3ef3c6abf739badf764a9d6dc2d3ce17f3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335323 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Mike Wasserman <msw@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/main@{#952453}

…ion. Change-Id: I9345beb90c9ea8be9e37e5a802e86090a8145ebb Bug: https://buganizer.corp.google.com/issues/200727244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344487 Reviewed-by: Curt Clemens <cclem@google.com> Commit-Queue: Brittany Hartmire <bhartmire@google.com> Cr-Commit-Position: refs/heads/main@{#952454}

… module. This update is part of work on replacing the old ToV8 interface with new ToV8Traits<IDLType>::ToV8 interface. Issue: Replace ToV8 with ToV8Traits<IDLType>::ToV8 Bug: 1199627 Change-Id: I36e4bd4753b6077cb1590d64dffe4ba3c19b8689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253447 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Vadym Kargin <vadym.kargin@accenture.com> Cr-Commit-Position: refs/heads/main@{#952455}

Add color and font to the dialog text. Test: manual Bug: 1276182 Change-Id: Ie2b1a078c988ac7474e195f7950e7740975c7524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340151 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Judy Wang <shidi@chromium.org> Cr-Commit-Position: refs/heads/main@{#952456}

This CL updates the icon tint in some classes to follow OmniboxTheme instead of the simple light/dark tint. It also moves OmniboxTheme out of chrome/browser/omnibox to be able to use it in classes outside omnibox/. Bug: 1233725, 1114183 Change-Id: I479854127613ca4bf3f28bf9ad6c79b8d127b877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307187 Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/main@{#952457}

…by 1y. This CL extends the histogram Extensions.Events.DispatchWithServiceWorkerBackground by 1y. This is a useful histogram to track manifest V3 extensions. Bug: 1263081 Change-Id: I23ce0aa18a5333cefee09596e9c4803cba93f2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343216 Reviewed-by: David Bertoni <dbertoni@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/main@{#952458}

This CL fixed capture label widget's visibility issue when the folder selection window is closed. Now when capture label widget doesn't overlap with setting menu, after selection window is closed, capture label is shown immediately. When capture label overlaps with settings menu, after selection window is closed, capture label is invisible until the settings menu is closed. Test: manual, added unit-tests Change-Id: I961a0afeb76bbdda492131bbee11ff45c92a4bd3 Fixed: 1279606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343186 Reviewed-by: Min Chen <minch@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Connie Xu <conniekxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952459}

The synchronize issue is because when Skia access is finished, all skia related works are recorded in skia's command buffer, but the command buffer is not submit to the GPU yet. So we need to call submit() before accessing the shared image backing out side of skia. Bug: 1264439,1280599 Change-Id: Ib62eb39e2a925bd898ca8a1998d39c4ec105e73e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345136 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#952460}

This patch restructures the privacy review HTML to use cr-view-manager to show and hide the various cards. This also required restructuring the associated TS file to explicitly show/hide the cards, rather than relying on Polymer to show the correct content. This patch also fixes a bug with the history sync card that was revealed with the above changes, and adds a feature to TestSyncBrowserProxy so that it's properly tested. Bug: 1215630 Change-Id: I888868dc9cdf9cc13d787c58c7791ab512f75fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3302818 Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Rainhard Findling <rainhard@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#952461}

As DLP print restriction is applied per WebContents, it can be checked inside LaCros based on the restrictions known in DlpContentManagerLacros. By moving CheckPrintingRestriction function to abstract DlpContentObserver interface it's made accessible from both Ash and Lacros. Bug: 1277494 Change-Id: Ibc774d80e05777b6a5920f297b0a25a6b2439ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320340 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#952462}

Add unit test which is responsible for checking if FingerprintError protobuf enum is converted properly to its counterpart in mojom. This test is similar to existing FingerprintScanResultConvertTest. Both tests are checking also if FingerprintMessage protobuf is converted properly to FingerprintMessage mojom union. BUG=b:184843581 b:197959527 TEST=autoninja -C out/Debug_chromeos/ services_unittests ./out/Debug_chromeos/services_unittests Change-Id: I18b93ed338a257898855de058b0b54d397d04c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331095 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Patryk Duda <patrykd@google.com> Cr-Commit-Position: refs/heads/main@{#952463}

https://android.googlesource.com/platform/external/perfetto.git/+log/15e3467297c3..9c674c8ed684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40dcff53677e545a4195389575c95647eb9128f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345540 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952464}

This update is part of work on replacing the old ToV8 interface with new ToV8Traits<IDLType>::ToV8 interface. Issue: Replace ToV8 with ToV8Traits<IDLType>::ToV8 Bug: 1199627 Change-Id: Idecf09bd72ebddde80c83e63208896125b1958e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253428 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/main@{#952465}

See bug comment 5. I think the test is tearing down the TryChromeDialog in an unnatural way, before Chrome has processed WM_ENDSESSION completely. This change attempts to spin the message loop to give time to handle that message and the resulting fallout. Bug: 1275995 Change-Id: I2635e789f6eb85be2afeebe1ef2b162b225551e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345541 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Travis Skare <skare@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/main@{#952466}

Bug: none Change-Id: I7c44db759b4e91f816e55992b3e873003c1fadcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340714 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#952467}

Currently when the templates grid is hidden while exiting overview, it is faded out. However while this fade out is occurring the user can still send events to it. This CL disables the event targeting for the templates grid right before it's faded out to avoid the aforementioned issue. Test: manual Bug: 1279992 Change-Id: I1a28c85511cd8de8bcd8e33b29241c09a7d90dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341642 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/main@{#952468}

Toggle is put into a read-only disabled state and a "learn more" link is added when the file access permissions are rejected on the connected Android device. Toggle enabled: https://screenshot.googleplex.com/7btkgPA38aTbWy2 Toggle disabled: https://screenshot.googleplex.com/3kKPcifwVsP5ZP8 Bug: 1221297 Change-Id: Iddb6d77328234d310ef7f057cbdb8a5196b3597e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321626 Reviewed-by: Jon Mann <jonmann@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Matt Walliser <mattwalliser@google.com> Cr-Commit-Position: refs/heads/main@{#952469}

https://chromium.googlesource.com/catapult.git/+log/1a164a8ef025..8f3d60691b27 2021-12-16 seanmccullough@google.com [telemetry] add macos arm64 binary for wpr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1268582,chromium:1269060,chromium:1278593 Tbr: wenbinzhang@google.com Change-Id: I9a24a0504f558f1a3184290024b512ea68bb3ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345482 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952470}

The C++ API handles setting a disconnect handler and does not require manually binding the Mojo interface. Bug: 1217301, 1269888 Change-Id: I988b37dd44c672fb1c4d7e2da94349d513e6704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344446 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/main@{#952471}

Infobar: https://screenshot.googleplex.com/9VMBoMo7mfy8vV3.png Message: https://screenshot.googleplex.com/4MqFKKkgb7jtnfQ.png Bug: 1276109 Change-Id: I8d086183c6d3735e7ef7d3d6c0ea2bc2f1199bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338985 Reviewed-by: Lijin Shen <lazzzis@google.com> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com> Cr-Commit-Position: refs/heads/main@{#952472}

Bug: None Change-Id: I947b5affe6c75716412547256429a8970a30667f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345139 Reviewed-by: Gavin Williams <gavinwill@chromium.org> Commit-Queue: Kyra Moed <kmoed@google.com> Cr-Commit-Position: refs/heads/main@{#952473}

Add haptic feedback to drag-to-drop haptic feedback. This also removes tick effect when the window being dragged reaches a desks. Test: HapticsUtilTest.HapticFeedbackForDragAndDrop Bug: 1277322 Change-Id: I0e35a374a39750a290330b569d5d14d115871d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342008 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Yongshun Liu <yongshun@chromium.org> Cr-Commit-Position: refs/heads/main@{#952474}

This is done by setting the pref on the policy layer instead of the disk layer. Change-Id: I418fec7d403931ec0f4cd7b3ab3b7fb0279369c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343767 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#952475}

This will fix the unexpected 3pp changes error as observed in https://ci.chromium.org/ui/p/chromium/builders/ci/3pp-linux-amd64-packager/1171/overview Change-Id: Icd882eb8f998d70e69653a43eeb29d103d7dda6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345634 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#952476}

Bug: 1180979 Change-Id: I2deef0769c3b38e7c51c7f81b2da74b2fb64eeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339919 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/main@{#952477}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/1cad40c1e720..3fc099b1f0bb 2021-12-16 smcallis@google.com Revert "Enabling build of callbox server." 2021-12-16 cmfcmf@chromium.org android: convert docstring types to typing hints 2021-12-16 cmfcmf@chromium.org test: convert docstring types to typing hints 2021-12-16 vapier@chromium.org command: rename decorator style 2021-12-16 briannorris@chromium.org osutils: Improve Mount() exception message 2021-12-16 sloanjohnson@google.com Reland "cros_run_unit_tests: Add --host option to run tests on host" 2021-12-16 cmfcmf@chromium.org binhost: convert docstring types to typing hints 2021-12-16 juahurta@google.com config: Actually disable unittests on skyrim-release 2021-12-15 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I89c1849453fa95f40c1bb40dc3b4a84710fd1ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345480 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952478}

Adds a metric to emit the result (success or failure) of key pair generation in the data encryptor. Change-Id: I90d728cd465b2404e8ba4a87dfb1ef1bd2f03c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331621 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#952479}

This file has been copied from https://docs.google.com/document/d/1zNEvf9g-F2WCto2uC7LLRccURnhlaQ0TzTXHIMe6M2U/edit, which will be updated to point to this README after submission. Change-Id: Ide6dcf624ccec2d594daa69e54a75c32a3864fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343220 Reviewed-by: Nicolás Peña <npm@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/main@{#952480}

Bug: 1280713 Change-Id: I35a9cd97aeb1cdbcdb9d49667c795502b7ec398c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345626 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Owners-Override: Justin DeWitt <dewittj@chromium.org> Auto-Submit: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/main@{#952481}

This CL migrates the desktop PaymentSheetViewControllerNoShippingTest suite tests that depend on basic-card. The migrated tests use a URL based payment method instead of basic-card. They are added as a new test suite so that coverage for the old path is preserved. Bug: 1221559 Change-Id: Ic07d53386a421f34335165ba344c372d3f6ad5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3318637 Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#952482}

https://android.googlesource.com/platform/external/perfetto.git/+log/15e3467297c3..9c674c8ed684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idc5c7d580e1e082f4c475cef0edc3dcb06a54c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345104 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952483}

https://chromium.googlesource.com/angle/angle.git/+log/e7413adff5a3..543f5750f70e 2021-12-16 cclao@google.com Vulkan: Disable protected memory for ARM 2021-12-16 msisov@igalia.com Add support for GL_MESA_framebuffer_flip_y 1/* 2021-12-16 lubosz.sarnecki@collabora.com Tests: Add Dota Underlords trace. 2021-12-16 lubosz.sarnecki@collabora.com Tests: Add My Talking Tom 2 trace. 2021-12-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from a8221eed5970 to 39f3a18bdfbe (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1231934 Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter="*dota_underlords*" Test: Test: angle_perftests --gtest_filter="*my_talking_tom2*" Change-Id: Ib901eb1b22298b594b1d948d74921a5016558521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345563 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952484}

This CL is adding an asynchronous version of GetDataResourceBytes to chrome content client. The WebUI resources are loaded and decompressed on the UI thread. These resources can be large JavaScript files and may be quite expensive to decompress on the browser main thread. This CL is adding an asynchronous way to load a data resource. This API is currently only used by the WebUI. To work fine, ui::ResourceBundle::LoadDataResourceBytes(...) must be thread-safe. Bug: 1191597 Change-Id: I2728768b8bd65d40a85509aa93a25c95d827515a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293193 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/main@{#952485}

Roll Chrome Linux PGO profile from chrome-linux-main-1639655564-a5a5c0d33ae436f2a30693fdb9d2306eb3190a81.profdata to chrome-linux-main-1639677539-99948628de3a78f947b1b4d59843ea500cf91b69.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I64cbc059d7f07004d7d3c822c8f6625193a89bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345606 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952486}

When the layout dumps were stitched together we would use web_contents()->GetMainFrame()->ForEachRenderFrameHost() but when requesting dumps we would use web_contents()->ForEachRenderFrameHost(). Since back/forward cache can share the FrameTreeNode ids it is possible that we'd iterate RenderFrameHosts in the back/forward cache and those would get already handled causing the DCHECK. There are two ways to fix this 1) Actually use a GlobalFrameRoutingID which uniquely maps to a RenderFrameHost 2) Fix the inconsistency which seems more correct. WebTest currently doesn't require dumps from prerender or bfcached pages so it is more appropriate to iterate only the active page. BUG=1267581 Change-Id: I9c6fa2ef612e3a85c3a569359418897cb36677be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345138 Reviewed-by: danakj chromium <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#952487}

If we call AwBrowserProcess.start() when the app context no longer has WebView's resources loaded we'll crash when trying to look up the resource that tells us if we're on a tablet or not, as this just happens to be the first resource loaded during initialization. There's some evidence that this may be a common scenario in the current spike we're seeing of problems with resources on Android 12 devices, when apps are using a background thread to initialize WebView. Since we don't actually access any resources until we're on the UI thread later in init, this is a reasonably good time to try adding the resources using the mechanism in WebViewDelegate, which should persist even if the initial add of the resources by WebViewFactory didn't, and since we're running on the UI thread it's very unlikely to be racing with anything else updating the app's resources. For now, only try this workaround when we *are* initializing WebView in a posted task from a background thread, on Android 12, and when trying to look up the resource in question actually fails, to limit the scope of new problems this might cause to cases where there's a good reason to believe it will help and we were almost certainly going to crash anyway. Bug: 1272888 Change-Id: I034383683cd73ac4420c3eca266faf0d0047361f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339195 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/main@{#952488}

Replace kmoed@ in string translation file since kmoed is leaving Chrome OS. Bug: None Change-Id: I56d6ffafda7e0282245382110fcc1c97e1d9dfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345440 Reviewed-by: Gavin Williams <gavinwill@chromium.org> Commit-Queue: Kyra Moed <kmoed@google.com> Cr-Commit-Position: refs/heads/main@{#952489}

This change makes Dino widget fill up the cell area while retaining its 1:1 aspect ratio. Core dimensions (padding, text size) are computed from the scale ratio; everything else is inferred by layouts. With resizing enabled, the widget behaves as follows: http://screen/7XVcfneNHzkCWsr Checked variants: - Regular Dino in Portrait and Landscape orientation - RTL screen layout direction - accessibility - unusual screen configurations (2x2 grid; extremely high scale ratio) - restore after reboot. Note on the last part: Android takes about 2 minutes after restart to complete most relevant initialization, before it fires the events to update the widgets. During these first 2 minutes the Widget may look different than expected (ie. will stretch to the entire content area). Soon as the Android system broadcasts the AppWidget UPDATE event, the Dino widget (as well as all other Chrome widgets) get updated. I consulted the matter with UX and there is no action required at this time. Bug: 1280029 Change-Id: Icfb90612ae7fdcf67b2714f40e4b0027454ce788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338084 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/main@{#952490}

Currently the position of the IME candidate window for the first composition character is off on Mac. The reason is that in RenderWidgetHostViewMac::GetCachedFirstRectForCharacterRange(), if the selection is collapsed, the rect (of the caret) is retrieved from GetSelectionRegion() which doesn't have info from EditContext. This CL addresses the issue by retrieving the rect from GetTextSelectionBounds(), which has correct character bounds if EditContext is active. This is the same logic we added in RenderWidgetHostViewAura::GetCaretBounds() when we introduced character bounds [1] (at the time, the path for Mac was missed) Note testing this scenario on Mac is non-trivial and the work will be done in a follow up CL tracked by [2] [1]: https://chromium-review.googlesource.com/c/chromium/src/+/3260767/13/content/browser/renderer_host/render_widget_host_view_aura.cc [2]: https://crbug.com/1280709 Bug: 999184 Change-Id: I1785f54826a3a78ac10a6e3a31c016a4d847048d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344717 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Alex Keng <shihken@microsoft.com> Cr-Commit-Position: refs/heads/main@{#952491}

Add GetBackdropWallpaperSuffix() to the wallpaper variant's url to ensure the high quality image is downloaded. Bug: 1280447 Test: Manually Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Id95dce1e110ca82515ca66a1562d7f4d7d1f4b9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344307 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jason Thai <jasontt@chromium.org> Cr-Commit-Position: refs/heads/main@{#952492}

Roll Chrome Win64 PGO profile from chrome-win64-main-1639655564-53960f02f5072242e6980160d511646ba3082008.profdata to chrome-win64-main-1639677539-e35fba550ec3048b103171c0e33ceac25ceda995.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I982cb12f4b324970f900986507856fe4f2b38538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345601 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952493}

It is handy to see in NDEBUG builds as well. Change-Id: I02611dfebb9d4e8214ea1e1e31890c32a74090f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345466 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952494}

Change-Id: If8a40ce3fbdd09eda2352eaa0625c3bae164b1a3 Bug: 210776377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340248 Reviewed-by: Ben Goldberger <benwgold@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/main@{#952495}

Bug: 1271011 Change-Id: I70b7dc60fc1b56eff4bcf8d476b2e3bfe67ebdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345637 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/main@{#952496}

https://android.googlesource.com/platform/external/perfetto.git/+log/15e3467297c3..9c674c8ed684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic656c4335d08678c1443756b2947495ea6d02871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345486 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952497}

Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ceb9223e..f5e412a1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I147c08aa0490586241a01459680228f72f53439a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344138 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952498}

Since we have only one controller per tab, it makes sense to allow only one EditAddressDialogView as well. Bug: 1278960 Change-Id: I8970ba453c6404e346372c68429544e38e5960b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344636 Reviewed-by: Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#952499}

If we have already broken before it, don't do it again, as we'd get stuck forever. Bug: 1280624 Change-Id: I39d04e9ee7d9a6237b516cb6610552dc1044e2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344659 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#952500}

…e comment Bug: 1270521 Change-Id: Ib18edb29211bed2fbbdcd87d13668c75512445d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344140 Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: thefrog <thefrog@chromium.org> Cr-Commit-Position: refs/heads/main@{#952501}

Roll Chrome Mac PGO profile from chrome-mac-main-1639655564-52e53ef7b47860477f68cddce2543fb594359e09.profdata to chrome-mac-main-1639677539-997cb311ab2c03187a535e6bd85a4c81ef7ed1a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If80f76757e7e1fa9114208c0d47a2b735d4afcda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343474 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952502}

This change adds all core members of the WebXR team (who should be OWNERS of all WebXR code) to components/webxr/OWNERS, and then updates all appropriate WebXR directories to reference this OWNERS file. Change-Id: I80f0295a3f3a252b6870efad665f8b1314b3ebff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345625 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#952503}

We are in the process of transferring the navigator.id API to navigator.credentials. There is one navigator.id test left which is already in navigator.credentials. This CL deletes the remaining navigator.id test and the test suite. BUG=1276618 Change-Id: Ibefd09a2618660808309a4307ff14c24701d6b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315839 Reviewed-by: Yi Gu <yigu@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/main@{#952504}

Bug: 1223910 Change-Id: I6b8dfc204f0d91280e3200c000c6757a64eea2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345548 Auto-Submit: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/main@{#952505}

This change will deallocate the NTP classes when there are no more active NTPs showing in any WebStates. didDetachWebState: will catch instances where the last visible NTP is removed with its WebState removal and newTabPageHelperDidChangeVisibility: will cover when the last visible NTP is hidden because of a navigation. Bug: 1279494 Change-Id: Id111a5e82a0b73fb496320d04a37bc9e7b5d18c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335191 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/main@{#952506}

https://webrtc.googlesource.com/src.git/+log/9754a43403e0..03cb7e5a6124 2021-12-16 saza@webrtc.org APM: Make echo detector an optionally compilable and injectable component If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idae946d7219f0aee4f7ebf270223193c6024a855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345605 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952507}

exclude infra/ from update fe19de6e1d00 arm64: Add Armv8.5-A BTI support to assembly files 2592a777cb34 Upgrade LUCI configs to use Mac-11 cfb5c846745a Reland "Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0""""" c1a7d9baea06 Revert "Reland "Reland "Reland "Reland "Reland "Bump Windows SDK to 10.0.19041.0"""""" a253f320d58a linux, win: allow disabling extra memory collection 05e4aedfb382 [googletest] Roll pin 398908903e0c Fuchsia: Migrate to zx_system_get_page_size a8683138db56 Reland x6 "Bump Windows SDK to 10.0.19041.0" 3e234dfe967c Revert "Reland x6 "Bump Windows SDK to 10.0.19041.0"" ff50a9e8c443 Reland x7 "Bump Windows SDK to 10.0.19041.0" b03c11533c14 Remove unnecessary lines in CaptureMemoryDelegate 5cc0d543d0e5 Remove obsolete LUCI experiment Change-Id: Iadc0563ae8b0f7461a39e2a83b17db5274989c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345723 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/main@{#952508}

Change-Id: I63cd8b5cc2ef6fd04cdaf8fca5fbcaa4fa1aed8b Bug: b/180967190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340679 Reviewed-by: Ben Goldberger <benwgold@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/main@{#952509}

The test is consistently failing on many bots. Apparently it loads data off chromium.org. It shouldn't run on bots until its hermetic. Bug: 1278535 Ignore-Freeze: true Change-Id: I841ce909e39d6df39672307a52689d622b23ce02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339494 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#952510}

If the user changes the order of apps within the apps grid, the app list should no more be considered sorted - i.e. the sorted state should revert to custom (as it's done if the user reorders apps during temporary sort). This means that any subsequent app installs should be added to the beginning of the app list (instead of in the sorted order). Also, fixes an issue where reparenting folder items to the root grid did not clear temporary sort state. BUG=1280436 Change-Id: I42648e4a12a149b3af69490704460cc4b3d3ab27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343225 Reviewed-by: Andrew Xu <andrewxu@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/main@{#952511}

To be used by upcoming Javascript extension API for authentication. This is replacing the current webui implementation and lays foundations for the eventual overhaul of the authentication dialog that would include potentially auth factors other than password depending on what's been configured. Change-Id: I519b6c18653d7bc57cc491c1c8f23231d8662ca1 Bug: 1271551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3275777 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Elie Maamari <emaamari@google.com> Cr-Commit-Position: refs/heads/main@{#952512}

https://gn.googlesource.com/gn.git/+log/2e56c317bd8e..18df6af86191 2021-12-16 zhaojiazhong-hf@loongson.cn Modify the naming convention of LoongArch64 platform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/gn-chromium-autoroll Please CC thakis@chromium.org,dpranke@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: thakis@chromium.org,dpranke@chromium.org Change-Id: I44a179b4aba26c656b014b38d34f0e1510630e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343470 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952513}

When a single tab is being shared using Screen Capture API, it should be checked for DLP restrictions on LaCros side as only it knows about the restrictions per-WebContents. Bug: 1278814 Test: Tests enabled on LaCros too. Change-Id: If6fa9f77c2a509ec8d778a190361e8097a77b5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330359 Reviewed-by: Aida Zolic <aidazolic@chromium.org> Reviewed-by: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#952514}

https://chromium.googlesource.com/catapult.git/+log/8f3d60691b27..2c2d76537b02 2021-12-16 heiserya@google.com Move delete_upload_tokens.py into Catapult If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1280352 Tbr: wenbinzhang@google.com Change-Id: Ia834763bd4974bab8bb469229c73a987a571c52c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345608 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952515}

…ple_url_loader.cc Change-Id: I3fe341af8bd0153038298c3a37494b3209d877fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3344624 Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/main@{#952516}

Fixes a crash when the FirmwareUpdater app is re-opened. The crash happens because the singleton, FirmwareUpdateManager, can only be bound to one receiver at a time but every instance of the FirmwareUpdater app will attempt to bind a new receiver. Bug: 1252981 Change-Id: I359900377e6f87b881f9fdd51e611aa041616a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343834 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/main@{#952517}

IDS_FINGERPRINT_LABEL_NOT_AUTHENTICATED >> IDS_ASH_LOGIN_FINGERPRINT_UNLOCK_DISABLED_FROM_ATTEMPTS IDS_ASH_LOGIN_FINGERPINT_UNLOCK_DISABLED_FROM_ATTEMPTS >> IDS_ASH_LOGIN_FINGERPRINT_UNLOCK_DISABLED_FROM_ATTEMPTS_OLD Bug: 1233614 Change-Id: I52e7e183b9d008700397077c3ad066683250f2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340671 Reviewed-by: Curt Clemens <cclem@google.com> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Thomas Tellier <tellier@google.com> Commit-Queue: Jason Rhee <jasonrhee@google.com> Cr-Commit-Position: refs/heads/main@{#952518}

Historically most navigations required IPC from browser to renderer and from renderer back to browser. This was done to check for before-unload handlers and occurred regardless of whether a before-unload handler was present. The navigation start time (as used in various metrics) is the time the renderer sends the IPC back to the browser. This means our metrics were not accounting for the cost of the IPC from the browser to renderer (navigation start is also not accounting for time actually spent processing the before-unload handler, but that is a separate issue). This patch updates navigation start so that it accounts for the cost of browser to renderer ipc. More specifically: navigation_start = time_renderer_sends_ipc_to_browser - (time_renderer_receives_ipc - time_browser_sends_ipc) It's the later part that is new. As this will impact FCP/LCP the change is behind a feature. BUG=365039 TEST=test only changes Change-Id: Ic746faba55c6edc34e3d09b114905d17d638b54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324423 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#952519}

Roll Chrome Win32 PGO profile from chrome-win32-main-1639666549-84a7c26e97b827581984ac991aa2569f15b40ef8.profdata to chrome-win32-main-1639677539-d3b89857331ec31b3fb9a2f0baec586c99a0d583.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iabc2e1edd230bd3d66bb51fdbd30c8ca55f6463d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345603 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952520}

Add const qualifiers to logically-const XRSpace methods, and mark cached fields as mutable. Fixed: 1031614 Change-Id: Iecc38e867abfb24e25121d7da2d1d6f0255bb6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345732 Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#952521}

The app menu dividers should not been lighlighted when pressed. We have set dividers to not focusable in divider_line_menu_item.xml, but it is not enough, we should also set dividers to enable(false). According to https://developer.android.com/reference/android/view/View, View does not support android:enabled in XML, so we need to programmatically set dividers enable(false). Bug: 1269897 Change-Id: Ia5a4683eb0b2079221aa4087d90a77f3edbdb76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345727 Reviewed-by: Theresa Sullivan <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/main@{#952522}

This CL adds more information on the segmentation internal page about each segment, and allows dev to toggle the display between detailed and simplified version. It also removes the GetSegment() IPC as the internal page will receive those information on page load. So there is no need for the page to retrieve them later. Bug: 1271839 Change-Id: I652ae3fb3459298119e9127a8ae09ce966a61eff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331035 Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/main@{#952523}

https://dawn.googlesource.com/dawn.git/+log/a2241d402e05..3649af2486cd 2021-12-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bda493258463 to 543f5750f70e (11 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I36950740f38a2703c6a78a5608f83e448b75894b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345609 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952524}

Adds a new feature param for omnibox::kZeroSuggestPrefetching used to place users in counterfactual groups. Counterfactual groups issue a follow-up non-cacheable request if the response is loaded from the HTTP cache. The new response is compared against the original cached response to determine HTTP cache validity which is recorded as a new entry for the following histograms: Omnibox.ZeroSuggestRequests.Prefetch Omnibox.ZeroSuggestRequests.NonPrefetch Bug: 1262373 Change-Id: I1e106e2fb4cd89ac545d6ad6fb2e0ee605662a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343634 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mohamad Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/main@{#952525}

The 3pp packages are updated at crrev.com/c/3345634, and created at https://ci.chromium.org/ui/p/chromium/builders/ci/3pp-linux-amd64-packager/1175/overview Change-Id: I90067ba044bce2d6de0bb0ac2047a5c8f5d15ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345728 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#952526}

Bug: 1280666 Change-Id: I157f7953b7dfa269186ba0d6f818e93794c6b00d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343469 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Owners-Override: Shrek Shao <shrekshao@google.com> Auto-Submit: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/main@{#952527}

Change-Id: I04db892b280706ff768aa3c1a267f3d57eea96a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3345840 Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#952528}

Adds a DEPS entry for a Mac arm64 version of goldctl for use on M1 devices and updates the Gold code to use the correct version. Bug: 1280002 Change-Id: I4135d95de255a9d131ae72d8801a515d735803d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343449 Reviewed-by: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/main@{#952529}

…alog https://chromium-review.googlesource.com/c/chromium/src/+/3342807 added logic to avoid showing the disambiguation dialog for external navigations, which breaks skew tests due to manifest entries that cause the disambiguation dialog to show, and a new test that won't work on older versions without the new logic. Bug: 1278017, 1251722 Change-Id: I2ee7f12499a1b3baadf3a85a919698c92acfa606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343913 Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/main@{#952530}

This replaces the four callbacks that were being passed into the VRDeviceProvider::Initialize method with a VRDeviceProviderClient interface. This helps to improve the readability of the methods, since some of the callbacks being passed into Initialize had quite a few parameters and were unwieldy. Further, this makes it simpler to provide a means for the device providers to access data should another expansion like that with the FrameSinkClient become necessary in the future. The use of a raw pointer being passed into Initialize which some of the VRDeviceProviders maintain a reference to is just as safe as the existing callback code, which used base::Unretained in it's bindings. This change should be a purely mechanical change, switching the use of the callbacks with direct calls onto a cached client object. Future improvements to this area could investigate a safer pattern, but the fact that the XRRuntimeManagerImpl is effectively a singleton and is guaranteed to outlive the providers is a fairly safe pattern. There are some further potential issues with the Orientation device provider, where if there is an already initialized device, we may not trigger the initialized callback; but it is unclear if this is a case that can actually be hit today, and was also left as-is in the interests of trying to keep this change mechanical. Bug: 864026 Change-Id: I9bf7648ff202cb5f9c0765aa31de707c0a72f936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3343629 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#952531}

The handling of ScopedCommitTrace was broken by: https://chromium-review.googlesource.com/c/chromium/src/+/3212131 Bug: 1280146 Change-Id: I36cab790d2cfc7db5880e125d9dd24b2387be9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342209 Reviewed-by: Vladimir Levin <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/main@{#952532}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] main from chromium:main #123

[pull] main from chromium:main #123

Commits on Dec 16, 2021