[pull] main from chromium:main #116

This CL extends the expiry date for the following histograms: - Signin.Extensions.GaiaRemoteConsentFlowResult by 3 months because we are planning to experiment with chrome.identity API soon - Signin.OAuth2MintToken.ApiCallResult by 6 months because this histogram is generally useful to monitor mint token API health Fixed: 1265522, 1277108 Change-Id: Iecab259099b20eda1d35042ad194a8709f1f050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339971 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/main@{#951865}

Fix DCHECK when scrolling through TableCellCatalogViewController. Change-Id: Ifce1ffdfdb5bb42fb1f0cb6675d7cb728fbf653c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338360 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951866}

We are in the process of moving all Autofill Assistant code to //components. For this we need to remove all dependencies on Chrome code. In the long term moving SharedPreferencesManager out of //chrome might be the best solution but due to time constraints we are removing our preferences from it for now. Bug: b/173103628 Change-Id: I25a5c8b4f89024832e2dcfdf63cac77cc9e11699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317417 Auto-Submit: Florian Gauger <fga@google.com> Reviewed-by: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Florian Gauger <fga@google.com> Cr-Commit-Position: refs/heads/main@{#951867}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3772b4e1977a..56b07585df4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I304000452a46e28583054bf9efbe85bcd6a62037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340820 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951868}

You'd think that in a VStack of image and text, SwiftUI would support some way to signal that you want the image to control the width of the stack and the text to just flow after that. But I couldn't find a way, so this CL just calculates the width of the icon and fixes the width of the entire Destination view at that width. Fixed: 1279876 Change-Id: I31d96baeb3220947b360ebbb8ca9900491f063b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338528 Reviewed-by: David Jean <djean@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/main@{#951869}

Remove usage of std::function and replace it with raw function pointers, as std::function is banned by the Chromium C++ style guide. See also https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++11.md#function-objects Additionally remove the usage of base::NoDestructor as it "is not needed because the templated class has a trivial destructor". Bug: 1237044 Test: python3 generate_policy_source_test.py Test: components_unittests --gtest_filter=PolicyProtoDecodersTest.* Test: Check manually that the same policies set via YAPS still appear in chrome://policy Change-Id: I49804e69d3372d50bca59eecd6c51f6c4ee14216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332720 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jana Grill <janagrill@google.com> Cr-Commit-Position: refs/heads/main@{#951870}

This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ibfd38d2c6c7b47fb4cb6cfa2f2e2d2986d90167e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340823 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951871}

Most functions do not support empty arguments, but var() is an exception; we should support an empty fallback (ie., second argument). Fixing this is also a prerequisite for properly stripping spaces when parsing custom CSS properties (otherwise we would turn a valid case into an invalid case). R=andruud@chromium.org Bug: 1220148 Change-Id: Ie1aa875bdec91bc0f48b7fa47bae6c0ab9e35006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338993 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#951872}

Update "Screen lock" string (that is shown for devices without PIN login support) to "Lock screen" to make it consistent with "Lock screen and sign-in" string (that is shown for devices with PIN login support). Bug: 1152711 Change-Id: If83740dc1cc05c473549b12b9ff195ea4cf5ff69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338339 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#951873}

Bug: 1279285 Change-Id: Ic04665eeff7548f1cb0605b39af3a8b8741c5fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341312 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951874}

If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: Id1a641da70b0353f2808065323a76bd24e14a9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340815 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951876}

If ML service is not available on the device, we should report document scanning as unsupported. Bug: b:209726834 Test: Manually Change-Id: I35091481b476608f88e2fac405ef9169d1c25881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327823 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951877}

These tests are failing on TSan due to a data race related to FeatureList. This CL attempts to fix the issue by initializing the test's ScopedFeatureList earlier, in the test fixture constructor instead of in SetUp(). Bug: 1278500 Change-Id: Id14dd86bf362e8c4f8f1de98dfc9a295dc1b02c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341532 Commit-Queue: Marc Treib <treib@chromium.org> Owners-Override: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951878}

For WebRtcVideoFrameAdapter, the RenderableGpuMemoryBufferVideoFramePool is created on one thread and used on another. Bug: 1278262 Change-Id: I3d535284418cf12dad1b8489c8cbfc6428229986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330362 Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#951879}

Using wpt-import in Chromium 0276eba. With Chromium commits locally applied on WPT: 6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies" 7cd9af9 "Always assume that non-auto 'columns' might create a multicol." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Id42e514070e7551cd146f00f3652b1332bdb5f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340752 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951880}

Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I00df0f8fb53aa833cb18a84f77e4e91db0c1f6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321547 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#951881}

The new tests pass with no code changes. Bug: 1278262 Change-Id: I000f4b635068f704fe83fdcc0bda3ac43294065f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338659 Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/main@{#951882}

Fixes the negative case of range adjustment of the conversion from v8::Value to int16_t. Bug: 1269182 Change-Id: I43d14fb60512665441c2c624685372511d3380b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293443 Reviewed-by: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#951883}

Add OWNERS files to Support Tool resource files as a follow-up to cl/3172793. Move support_tool* files under chrome/browser/ui/webui to their own dedicated folder. BUG=b:199691085 TEST-None. Change-Id: I08b30ae731fa31a86f89dd573b43ea0cb2344a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338912 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Irem Uguz <iremuguz@google.com> Cr-Commit-Position: refs/heads/main@{#951884}

Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I0e8c019bc0a7fd30afc55ee994c46083590efd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320456 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#951885}

Bug: b:172340451 Test: tsc compiles Change-Id: I3a16cb498892b5e36ce35c6cc954af54c6a77ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299753 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951886}

CL uses the existing auxiliary text functionality provided by the TreeView to expose the partitioned status of cookies within the CollectedCookiesViews. New functionality is added to the TreeView to support independently coloring the auxiliary text, and line-end padding is introduced to improve the view layout. Bug: 1279760 Change-Id: I44f46dc4c177c0559ecacfd4851ceb551183b27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307040 Reviewed-by: Mike Wasserman <msw@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/main@{#951887}

This patch fixes separator issue: https://screenshot.googleplex.com/8exAX9YE8uxyrzk Dark mode: before: https://drive.google.com/file/d/1XgVFxbu1R5NTl1pj-whQzqin37OhuokP/view?usp=sharing&resourcekey=0-4XAIKPp7gWGHMfJ6MLCwTg after: https://drive.google.com/file/d/1Ap9XqAKzq1M1q1AcFTnbypl9JqZOgVrW/view?usp=sharing&resourcekey=0-K6sWS7rWJU2O8c9D4jE7bA Light mode: before: https://drive.google.com/file/d/1J7Puy8knURtmGy9u9XAyIuJ8kK6kCX2T/view?usp=sharing&resourcekey=0---XGNqRbQ4CYIvlv1KVcwg after: https://drive.google.com/file/d/1BNJlRTWdBiLWvE6bzZ_wPUSOkfqaMwdx/view?usp=sharing&resourcekey=0-FYrWe93Z9HlpGcFdHNyo2A Fixed: 1261887 Change-Id: If37c571a7aaa50d2b947136caa3b85cce85686e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339313 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951888}

…k-98.0.4758.7-r1 to 98-4744.1-1639397847-benchmark-98.0.4758.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iaca90e9732dbae4a0864ee66a9e9e819204e5d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341613 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951889}

The context menu should be displaying the full URL on more line to give more information to the user. Fixed: 1278734 Change-Id: I459a20b66ffaf80037a7039ad803b26de8e397de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341053 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/main@{#951890}

Namely is_incognito_deprecated and restore_last_session_deprecated. They are unused (the information is encoded via initial_browser_action instead). Bug: chromium:1194304 Change-Id: Ia8f74d3eee6a4129782e09afaf41c2f093d3d968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329856 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951891}

Bug: 1279102 Change-Id: Ic3305f4778ad436124c41316950ba2563504a664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340935 Reviewed-by: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#951892}

…8.0.4758.7-r1 to 98-4744.1-1639393599-benchmark-98.0.4758.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I986cd13090609858325037ff5d0cdc3ba43b64f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341615 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951893}

Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202112150100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/jZ1wDChducDMF-MWFvXLkLZpk_AWan76x5hDRvEhqLoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/206375321,b/210012141,b/210057761 Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: Ia5a46d789110e84c5def91580e907127dc49258d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341371 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951894}

With the recent https://crrev.com/c/3327210 the parent GUID in BookmarkSpecifics is considered mandatory, which is possible because legacy data downloaded from the server gets the field auto-populated client-side. This allows rewriting BookmarkRemoteUpdatesHandler to be GUID-centric rather than sync-id-centric, which unblocks the deprecation of the legacy field |SyncEntity.parent_id|, no longer consumed for incremental updates (with the exception of legacy data, which relies on this field for auto-populating the parent GUID). The rewrite should not lead to user-visible behavioral differences, at least for users in a non-corrupt state, but this is hard to prove so let's keep an eye on the various UMA metrics for incremental updates to rule out regressions. Bug: 1274122 Change-Id: Iacc125edfdaa53df7f0d868f8cfa438831d3a95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327034 Reviewed-by: Rushan Suleymanov <rushans@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951895}

Refactor use cases of ProfileIsSupervised method to reflect supervised user terminology "child account". Bug: 1275169 Change-Id: I433ffa32dd321aaf27915349e09c02b20c3d5c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339011 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/main@{#951896}

The meaning of "o" is not obvious, so renaming to "stay_within". There should be no behaviour change. Bug: none Change-Id: I870b1d89a10c24b0e407e9af3055e751050417c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338703 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/main@{#951897}

…ngs" This is a reland of 293ef66, updated to avoid breaking PasswordSettingsTest#testManageAccountLinkSyncing() by making sure the test mimics sync having been fully initialized. Original change's description: > [Passwords] Fix assertion failure when opening password settings > > Method SyncService.isUsingExplicitPassphrase() has the precondition that > the sync engine must have initialized, as per isEngineInitialized(). To > avoiding running into assertion failures, PasswordManagerHelper must > first rule out ongoing initialization before invoking > isUsingExplicitPassphrase(). > > Change-Id: I8f519953c6d37aa4d9d54e6b043c24054fb46b45 > Fixed: 1276532 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336879 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951464} Change-Id: I280c58064ba674e1573c938002bdb301fc5d6533 Fixed: 1276532, 1279940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341531 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951898}

This reverts commit b3dbfd3. Reason for revert: causes test failures - https://crbug.com/1280165 - https://crbug.com/1280172 - https://crbug.com/1280173 - https://crbug.com/1280174 Please fix the tests before re-enabling this config. Original change's description: > [LR] Add fieldtrial config entry > > Adds a fieldtriel testing config entry for Lightweight Reactions in > preparation for ramping up the experiment to Beta. > > Change-Id: I97be1f7233637c5e4b316ddbb32ae39d7a93890f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3331121 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Guillaume Jenkins <gujen@google.com> > Cr-Commit-Position: refs/heads/main@{#951592} Change-Id: I393c2f72ee983e3509b9431d9a29b62077286a1f Fixed: 1280165, 1280172, 1280173, 1280174 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341057 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951899}

Bug: b:172340451 Test: tsc compiles Change-Id: Iec72dce673bbde380fa2eaabaff450f5c3440d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299883 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951900}

Roll Chrome Win32 PGO profile from chrome-win32-main-1639547758-c53f46e146f64fe801bea0f5145ea9a0eb37f478.profdata to chrome-win32-main-1639558498-bfc8cbd53a95441e4b362960336fa324f065b029.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I25cf92784a8ae685bafebe38b2808d873e5a0738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341471 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951901}

Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/9336be04a2..1065514ef3 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/9336be04a2..1065514ef3 Bug: None Change-Id: Ib32981a1f8775319d102530494d800fa5b65e9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341051 Reviewed-by: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/main@{#951902}

If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/fuchsia-internal-sdk-chromium Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: Icf18e442ec2505aa504a949ee0743ebf8193c9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341616 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951903}

The code that checks if libinput needs to be used for touchpad, is not depending on the libinput. This commit completes changes from https://chromium-review.googlesource.com/c/chromium/src/+/3211447 Bug: b:208192332 Change-Id: I893cb1eaf0d8a0d0875368b45c4e80de76d46ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330203 Reviewed-by: Kerker Yang <kerker@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/main@{#951904}

Since https://crrev.com/c/3318298, AutofillAgent::DataListOptionsChanged() schedules a AutofillAgent::BatchDataListOptionChange() call in any case. This is a performance regression if a site adds or removes huge amounts of datalist <option>s to/from the DOM. This CL moves the early return from BatchDataListOptionChange() to DataListOptionsChanged() to fix this issue. Bug: 1278852, 721655 Change-Id: I73fa24e57bebbef13cd850259f68003c8845c344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330364 Reviewed-by: Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#951905}

Allows concurrent marking of the following objects: - NodeEventContext - NGInlineItem - NGOffsetMappingUnit Those types have been observed to be the main culprits for main-thread marking of C++ objects on some benchmarks. Bug: chromium:1278278 Change-Id: I9271282f1072e9cbd08dde1bcb65c2d66ff1b2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327212 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951906}

settings-multidevice-wifi-sync-item uses osWifiConfigurationsSynced to determine whether Wifi sync is enabled [1], so it the corresponding test should set the same variable, not wifiConfigurationsSynced. [1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/settings/chromeos/multidevice_page/multidevice_wifi_sync_item.js;l=76;drc=0dbd3c6bf4ca3e6b25b26b4c1c76f8b8372041e7 Bug: None Change-Id: I8f605f29b6ae00ac3e9d60f7a3135e96d28d3eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338423 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#951907}

Previously they showed up with an odd drop shadow (screenshot: http://shortn/_XXWPdBMgog). Change-Id: I5ef126f6e089bcddf400a0046ea296a60140fa93 Bug: 1207678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3324686 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/main@{#951908}

We invalidated NGAbstractInlineTextBoxCache after having removed one of the fragments, so that we would get a false hit later on. The test included would crash when run with --force-renderer-accessibility Bug: 1278439 Change-Id: I4fde6c4590a04ffbc9e371cf17fef17f1449d531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338913 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951909}

Normally PerfettoPlatform should be initialized with singleton task runner which will be valid in different test suites which run in the same process. Usually this achived by using base::test::TracingEnvironment. TracingConsumerTest.* tests does not use this utility class. This leads to the problem if this tests run before any other test sutes which uses PerfettoPlatform. TracingConsumerTest.* initiliazes PerfettoPlatform with task runner which does not outlive current test. This leads to the problem with TracingMuxerImpl. It uses PerfettoPlatform task runner for shutdown. Because task runner is invalid TracingMuxerImpl cannot shutdown correctly and hangs on conditional variable. This problem does not reproduce if test with TracingEnvironment runs first. But if TracingConsumerTest is first then services_unittests hangs in the end. To reproduce run: services_unittests \ --gtest_filter=TracingConsumerTest.EnableAndDisableTracing:\ PerfettoIntegrationTest.ClientEnabledAndDisabled I think this can be fixed by subclassing TracingConsumerTest from TracingUnitTest but I'm not familiar with this test suit to make such extensive change. Change-Id: Ie74767307d62dec2c02b3718c290b622d132927c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3311071 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/main@{#951910}

Instead of using Skia. This is done when the first access to the backing is done through GL. In that case we need a signaled semaphore to call glWaitSemaphoresEXT but we don't have one. Instead of using Skia to do that, we can directly use the vulkan helpers to do it. Bug: chromium:1279419 Change-Id: I920117e8e9e909ccf70bcaed46cba462deff2db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334550 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951911}

This patch makes `BrowserDataMigrator::MaybeRestartToMigrate()` return true if `chrome::AttemptRestart()` is called to start profile migration. Then in both UserSessionManager::DoBrowserLaunchInternal() and ChromeBrowserMainPartsAsh::PreProfileInit() return immediately if migration is started and avoid further going down the initialization steps. This should prevent any race condition between starting the session and the restart which could potentially corrupt session data. Bug: 1272799 Change-Id: If7d47934ac79a664ec5fe60a5a9605d6948c960c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3325718 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/main@{#951912}

This is a partial revert of crrev.com/c/3322017 which converted a bunch of bluetooth requestDevice tests to "standalone window" tests. That made this particular test flaky on Webkit Linux Leak, so this CL reverts this one test back to the old version. Bug: 994756, 1280218 Change-Id: Id539b93a0b47187e8124f615c3dd6897a8f1ef59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341457 Reviewed-by: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#951913}

Removes the code gated by SyncConsentOptional feature flag, as well as OsSyncFeatureEnabled pref (that becomes redundant without SyncConsentOptional). Bug: 1274802 Change-Id: I70c1352f3c75551b6d0601d83b2b5b5eb02cee61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307058 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#951914}

Changed DlpClient to be able to send query to the DLP daemon to get files source urls. Bug: 1259203 Change-Id: Idca486db9bf0d2475a02716317ddfd37093f019e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329865 Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951915}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56b07585df4f..3b07df95bd2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC treib@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1215467,chromium:1278252 Tbr: treib@google.com Change-Id: I070ed33c92ef3525eb9cf272966aeb6e98b25edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341618 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951916}

https://webrtc.googlesource.com/src.git/+log/63b97de330fe..d525e2d9f71f 2021-12-15 ngrunbaum@mozilla.com Disambiguate kIvfHeaderSize for Mozilla unified build 2021-12-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 80e2ab3..03bde11 (951734:951854) 2021-12-15 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-12-15T04:02:29). 2021-12-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d02ff77..80e2ab3 (951612:951734) 2021-12-14 mbonadei@webrtc.org Remove forward header. 2021-12-14 emaxx@chromium.org Fix use-after-move in RTCErrorOr 2021-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 34c6b23..d02ff77 (951511:951612) 2021-12-14 jleconte@webrtc.org Remove perf test isac_fix_test. 2021-12-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 637713d..34c6b23 (951378:951511) 2021-12-14 kay.k@hpcnt.com Implement JNI and objc implementation for icecandidateerror event If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1122844 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I68eac5dd01c9f59dd0e3a9b3266712139d3effe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341612 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951917}

Bug: 1260909 Change-Id: Iddbc744b19c951553baf51a790f57b2f11f1906a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340713 Reviewed-by: Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#951918}

Roll Chrome Linux PGO profile from chrome-linux-main-1639547758-3c0c7f6ddbe718d4afe3c997d77be5e727f691a0.profdata to chrome-linux-main-1639569614-51af581decdc00b7af5310dccd59d8dd19f402a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia52b4aa588cdba1da19bba4c9982105c22d79823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341837 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951919}

This is needed to deprecate the LocalPolicyTestServer. Bug: 1269330 Change-Id: I9f9d18b74b728db98c4c8dc9910f564c0fe6b007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3279741 Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Auto-Submit: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951920}

The following histograms have expired ~3 years ago and are no longer recorded: - CustomTabs.ResourcePrefetch.Duration.Failure - CustomTabs.ResourcePrefetch.Duration.Success - CustomTabs.ResourcePrefetch.FinalStatus Fixed: 915899 Change-Id: I569ddd6b812d3c4ddfd4a3159b4430fa8dcb1e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338355 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Benoit Lize <lizeb@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#951921}

This used to be a parse error, now it's simply allowed. R=andruud@chromium.org Bug: 1220149 Change-Id: I61e10aab1c155c6cfcab3ad19c3934382881f448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338992 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#951922}

We are in the process of moving all Autofill Assistant code to //components. For this we need to remove all dependencies on Chrome code. Moving and implementing the whole TabObsucringHandler interface would a significant amount of work. Since we might be okay to not support this functionality in our first implementation we will for now create a proxy interface and look at how to implement this in WebLayer further down the road. Bug: b/173103628 Change-Id: Ieddecd35bd2bd0e3631daab6d821f00cee5773eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330457 Auto-Submit: Florian Gauger <fga@google.com> Reviewed-by: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Florian Gauger <fga@google.com> Cr-Commit-Position: refs/heads/main@{#951923}

Fixed: 1278158 Change-Id: I3e558b78cd55737cd7506295fb1777341300f8ff Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339493 Reviewed-by: Joey Arhar <jarhar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#951924}

Roll Chrome Mac PGO profile from chrome-mac-main-1639547758-fd2664057f711ddaea1d69c1956e0a914a71290f.profdata to chrome-mac-main-1639569614-d251f83da686019cc9a1332b1064979740a5536b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iea5e40ba47bd784f42f8aa061765cd927ee185a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341831 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951925}

Bug: 716930 Change-Id: Ifae437f46e4cfe129e459c0e9bcd636b23b90361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341178 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951926}

This reverts commit 2d3725b. Reason for revert: Reland with -fno-whole-program-vtables Original change's description: > Revert "Reland "Reland "Mac: enable ThinLTO (without unit splitting)""" > > This reverts commit bc7e870. > > Reason for revert: Installer is still seeing -fwhole-program-vtables > > Original change's description: > > Reland "Reland "Mac: enable ThinLTO (without unit splitting)"" > > > > This reverts commit 8f1d535. > > > > Reason for revert: Turned off LTO for ARM installer > > > > Original change's description: > > > Revert "Reland "Mac: enable ThinLTO (without unit splitting)"" > > > > > > This reverts commit af0abed. > > > > > > Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1279316 > > > > > > Original change's description: > > > > Reland "Mac: enable ThinLTO (without unit splitting)" > > > > > > > > This reverts commit 397efe0. > > > > > > > > Reason for revert: Timeout on bot was increased > > > > > > > > Original change's description: > > > > > Revert "Mac: enable ThinLTO (without unit splitting)" > > > > > > > > > > This reverts commit 810d213. > > > > > > > > > > Reason for revert: Suspecting causing infra failure. > > > > > > > > > > Original change's description: > > > > > > Mac: enable ThinLTO (without unit splitting) > > > > > > > > > > > > Splitting is currently blocked on supporting N_INDR symbols in lld. > > > > > > > > > > > > Bug: 471146 > > > > > > Change-Id: Iacc2288d8307fdf730d92d0bfc7f3286d0162b92 > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328741 > > > > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > > > > Commit-Queue: Nico Weber <thakis@chromium.org> > > > > > > Cr-Commit-Position: refs/heads/main@{#950412} > > > > > > > > > > Bug: 1279290 > > > > > Change-Id: If82f13cf72eb7a42430dbda9d5af534efd77f5f6 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332866 > > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > > Commit-Queue: My Nguyen <myy@chromium.org> > > > > > Owners-Override: My Nguyen <myy@chromium.org> > > > > > Reviewed-by: Darren Shen <shend@chromium.org> > > > > > Cr-Commit-Position: refs/heads/main@{#950944} > > > > > > > > Bug: 1279290 > > > > Change-Id: I42d2f45910992dcd02912a10e080d4392253b31e > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334918 > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > Reviewed-by: Nico Weber <thakis@chromium.org> > > > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#951187} > > > > > > Bug: 1279290 > > > Change-Id: I60ca717f12e620ecd1ea38944714feeee244e7f5 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3336736 > > > Auto-Submit: Leonard Grey <lgrey@chromium.org> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Reviewed-by: Mark Mentovai <mark@chromium.org> > > > Owners-Override: Ben Pastene <bpastene@chromium.org> > > > Commit-Queue: Leonard Grey <lgrey@chromium.org> > > > Reviewed-by: My Nguyen <myy@chromium.org> > > > Commit-Queue: My Nguyen <myy@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#951260} > > > > Bug: 471146 > > Change-Id: Ide0a3b124736513871afa9e7be81faa611072847 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338759 > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#951594} > > Bug: 471146 > Change-Id: Ia3ca62dbe13fc438414f594b5e73c2f6c47a30b5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339577 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Owners-Override: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/main@{#951691} Bug: 471146 Change-Id: Ia4ee3af1776d0b9169ddc2b07020a0c3604807db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339281 Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951927}

Bug: 1273975 Change-Id: I312fec39a2bf6909feda3c5681f30ef58bbc5af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338862 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Osama Fathy <osamafathy@google.com> Cr-Commit-Position: refs/heads/main@{#951928}

Since CopyRGBATextureToVideoFrame only deals with textures, only the coded size is carried over from the source frame. Scaling and cropping metadata then need to be applied to the output frame. Also fix flakiness in mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html -- ran 100 iterations successfully. Bug: 1272852, 1232417 Change-Id: Iab614e245ff4d3e27bbbf58bf6bebd2d5463b58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338915 Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Reviewed-by: Tony Herre <toprice@chromium.org> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#951929}

The underlying issue https://crbug.com/1228485 is supposedly fixed. Let's see if the test is no longer flaky. Fixed: 1232030 Change-Id: I821904729c24ec15a4a16d1be81f57a6b9b00c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341534 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#951930}

Bug: 1280213 Change-Id: If7d0efb0ea3c343234bd6f7990d3cf6969e3de04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330205 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/main@{#951931}

Looks like HttpNetworkTransaction handles auth restart. Also we no longer record HttpStreamFactory::Job related UMAs. Bug: N/A Change-Id: I7bfdd9fd2c2faac36ca09ed3a39bd5230908c960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340973 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#951932}

Bug: 1280223 Change-Id: Ie41f00b8d136e5cd99f5eaf8d5a5f6151e42aac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341460 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#951933}

This avoids using Skia to upload CPU data to the Vulkan texture and instead reuses an existing path. Also removes the unused stride argument of WritePixelsWithCallback and inlines WritePixels in its only call site. Bug: chromium:1279419 Change-Id: I847db28dbf59618ff9bd05c0af010693f5a53293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332719 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/main@{#951934}

…llowLists In order to extract the changed parts of allow lists for the next CL (part 8) we need access to the raw allow list in the permissions policy. This CL adds a way to access it and tests the path. This CL is a part of a series: (1) Add Feature (2) Add 'name' identical to 'http-equiv' version (3) Lock 'name' version to pre-execution text state (4) Add third-party delegation parser (5) Add ability to modify PermissionsPolicy (6) Add 'name' support for third-party subresources (7) Add ability to extract raw AllowLists (8) Add 'name' support for third-party iframes (9) Enable by default (10) Add webtests Bug: 1219359 Change-Id: I475bcc0978a5d78f57628f9336627cd3bfceaef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339452 Auto-Submit: Ari Chivukula <arichiv@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/main@{#951935}

https://chromium.googlesource.com/angle/angle.git/+log/36fcf80b1f2a..8419f4fcd1ec 2021-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c03890076954 to a8221eed5970 (2 revisions) 2021-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0c0a365 to 2dae07e (450 revisions) 2021-12-15 cnorthrop@google.com Revert "Upgrade restricted traces to new trace format." 2021-12-15 yuxinhu@google.com Modified buffer fallback format to smaller storage format 2021-12-15 cnorthrop@google.com Revert "Trace Tests: Remove auto-generated code." 2021-12-15 shrekshao@google.com Skip MultithreadingTest.MultiContextDrawWithSwapBuffers 2021-12-15 iannucci@chromium.org Switch to non-deprecated bbagent, remove defunct experiments. 2021-12-14 lexa.knyazev@gmail.com Add WebGLCompressedTextureAvailabilityTest 2021-12-14 shrekshao@google.com BufferSubDataTest.SmallIndexBufferUpdateAfterDraw testSetUp fix 2021-12-14 m.maiya@samsung.com Vulkan: Rectify typo introduced in 36fcf80b1f2a99 2021-12-14 jmadill@chromium.org Trace Tests: Remove auto-generated code. 2021-12-14 kpiddington@apple.com Metal: ETC and ASTC are missing on M1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1015181,chromium:1279908 Tbr: timvp@google.com Test: Test: Texture2DTestES3.*Yuv*Vulkan Change-Id: I387179bc579708f1f488f7d57fbdf3cb349015c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341826 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951936}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8b004bd56791..b47975a82916 2021-12-15 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-12-15 tvanderlippe@chromium.org Migrate to private class methods in ui/components 2021-12-15 aerotwist@chromium.org Remove patchColorText in Network Panel 2021-12-15 tvanderlippe@chromium.org Update migration script for private class methods 2021-12-15 tikuta@chromium.org use urllib.request.urlcleanup() in download_emscripten.py 2021-12-15 tvanderlippe@chromium.org Migrate to private class fields in entrypoints/ 2021-12-15 aerotwist@chromium.org Deprecate patchColor* functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1222126,chromium:1278738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I63c562631e7cccc00773f5fe6470b66e22f4a0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341294 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951937}

https://android.googlesource.com/platform/external/perfetto.git/+log/f9abf9948a18..22467673a50f 2021-12-15 lalitm@google.com Merge "metric: fix incorrect function to remove suffix string" 2021-12-15 lukechang@google.com trace_processor: support net_dev_xmit event If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:210794350 Tbr: perfetto-bugs@google.com Test: Test: tools/diff_test_trace_processor.py <trace_processor_shell> \ Change-Id: I7212f082f6e346b78bdcce7ee792d5e269ff7ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341967 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951938}

Removes unused #include lines for base/no_destructor.h and adds them to files which use base::NoDestructor but did not have the #include. Net result is a slight decrease in overall build size from trimming the unused #include lines. AX-Relnotes: n/a. Bug: 242216 Change-Id: I73f58233657b37b00bdc1e8322e078919519a379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340088 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Austin Tankiang <austinct@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Owners-Override: Nico Weber <thakis@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#951939}

R=emaxx Bug: 989634 Change-Id: I9d5c93ab4321d76d6c5b66db27916613e17710cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3326949 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleksandr Kulkov <melfice@google.com> Cr-Commit-Position: refs/heads/main@{#951940}

RunsAudioVideoWebRTCCallInTwoTabsEmitsGatheringStateChange_ConnectionCount for Windows Bug: 1239275 Change-Id: Ib2c0591628a7e80b3c1af1104158961bf2c32b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3291599 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Palak Agarwal <agpalak@chromium.org> Cr-Commit-Position: refs/heads/main@{#951941}

For context, see go/lacros-accessibility. This change redefines the way popups such as those by right clicking, get hooked up for Lacros in the accessibility tree. Previously, this was done indirectly by creating a node in the Ash accessibility tree which unconditionally points to the root of the Lacros tree. This root was guaranteed to contain the popup. https://chromium-review.googlesource.com/c/chromium/src/+/3147249 https://chromium-review.googlesource.com/c/chromium/src/+/3202451 This workaround simply hides the underlying issue. The core issue is that a PlatformWindow (subclass WaylandPopup) has no parents in the PlatformWindow tree, but exposes a parent in the WaylandWindow tree. This case is different from a WaylandTopLevelWindow. This change obtains the root PlatformWindow by walking through all DesktopWindowTreeHostPlatform::window_parent. Fixed: 1266416 Test: browser_tests --lacros-chrome-path=out/LacrosDesktop --gtest_filter=ChromeVox*.*Menu* Change-Id: I35b46518f9894b6203111da5d639f9a7ac7be352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3319456 Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: Keren Zhu <kerenzhu@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#951942}

web_launch::WebLaunchFilesHelper becomes web_app::WebLaunchParamsHelper and the scope extension check is corrected. Bug: 1250225 Change-Id: I0abf147ab3e562d309358fa48c471575a9883275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327680 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/main@{#951943}

This CL changes the ShadowTrafficMetricsRecorder class to support other types than LoginsOrErrorReply. This is done by 2 things: 1- Include template parameters for method that create a copy and compare the type of the passed in elements. 2- Introduce different callback for types that contains an error, and those that don't! Follow-up CLs will be able to use all such generic infrastructure to report metrics for all other methods! Bug: 1274610 Change-Id: I9a7f331279427bbce8260cb18fab6ab67bf83f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3308692 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/main@{#951944}

Roll Chrome Win64 PGO profile from chrome-win64-main-1639547758-bf72085c8dc2497e7f9dce81ad2bc968a38120aa.profdata to chrome-win64-main-1639569614-a364248aacb276f65024141a5cfb87f1882ed3eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4deb0a34dcb90d21825460f205ea2248890f3dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341830 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951945}

Found via lsan. Some clean up were done in a task runner, so having the task environment wait until all the tasks have been run ensured objects were cleaned up. Bug: 1280067 Change-Id: I45e2f821512b056f3754654523c666962763d74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340238 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/main@{#951946}

GetPage already gets the document associated data from the associated MainFrame. So we don't need to get the page from the main frame as it seems odd. BUG=1252039 Change-Id: I06fc85f804b9ad15da65b4ef3e005c01b3edbd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338387 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#951947}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9e5809e98f33..48b35e123dff 2021-12-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,gavinmak@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: apolito@google.com,gavinmak@google.com,sokcevic@google.com,ajp@google.com Change-Id: I4e6d2c3ede59924745be89e5179b8600333ba074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341827 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951948}

Bug: 1264439 Change-Id: I93e0c80e97e2056b6ec30f1695d44ff6b1ea3c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339000 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/main@{#951949}

Firstly, this CL move constructors and assignments to the history::Cluster, Cluster, history::ClusterVisit, Visit, and history::AnnotatedVisit structures. Secondly, the `CollapseDuplicateVisits` algorithm is rewritten to 1) avoid copies, 2) reduce the # of map insertions, and 3) avoid needing to do map removals. This comes at the cost of additional set and vector insertions, details below. The motivation here is primarily to avoid copies, not to reduce container manipulation as the size of these containers is relatively small. Given: N visits, of which D are duplicates, and C are canonical; (N=D+C) map insert| map lookup| map remove| vector insert| set insert Before N | D | D | N | 0 After D | D | 0 | N+C | D Bug: 1262016 Change-Id: I297b01da8d343b0223c55c9b6d3c7bf19f5ef507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339593 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/main@{#951950}

When the continue task views are displaying a context menu, a ripple should show to highlight the view. Ensure as well that as the context menu is closed, the ripple should hide. Bug: 1276233 Change-Id: Iab5b83ea9db9f57cf70cc2b945fb7469ff3b20cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330778 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951951}

If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-windows-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: I7a27f7418da6c92abd34280a2350596aa7c895a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341775 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951952}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b07df95bd2e..b52ee54b2a18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC treib@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1278252 Tbr: treib@google.com Change-Id: I5479849ece9c97fbffe36d9018749a67a975de6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341769 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951953}

Bug: 1280271 Change-Id: I2be0583f78556e18b3a203dbb8b2e974d06e5a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342147 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Brianna Goldstein <brgoldstein@google.com> Cr-Commit-Position: refs/heads/main@{#951954}

R=tvanderlippe@chromium.org Bug: 1278738 Change-Id: I8d3989f89161f0237ca7e6e0d7b305303a3fe986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341059 Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/main@{#951955}

This CL adds dedicated flag for shared highlighting v2 ios Change-Id: Idd206bffc355a3f3b1a0bf3c53cee2416e29de04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338326 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/main@{#951956}

* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: I2497e14b5a6af08473898b48a1a25b3b23653fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342246 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951957}

Fixed: 1229893 Change-Id: I2896c60f5531e538553fa9307440c7d082043bdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338422 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/main@{#951958}

Not all of the types in ui/events/types/scroll_types.h are handled in ThreadedInputHandler::ResolveScrollGranularityToPixels(). For more info look at ScrollableArea::ResolveScrollDelta() Bug: 1248588 Change-Id: Ic99f9d7954c1864af8e5a347a82f85671c7d49d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3304814 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Mehdi Kazemi <mehdika@chromium.org> Cr-Commit-Position: refs/heads/main@{#951959}

DestroyWindow() will land in the WM_DESTROY handler which has the dialog manager delete the dialog. Then the stack unwinds to Cancel() inside the deleted dialog, and it tries to keep using `this`. R=sky@chromium.org Bug: 1279042 Change-Id: I521cf57406a013c2a6ab4ddfb6e465e3f488ec9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339492 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: danakj chromium <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#951960}

shell-encryption and private_membership leaked some configs which disable some default warnings. In order to re-enable all these warnings for chrome/browser/* in this CL crrev.com/c/3303510, all warnings need to be fixed. This CL is fixing the comparison between two integers for them to be from the same exact type (i.e. integer). Bug: chromium:1212837, b:201763017 Change-Id: Ie83e2b56b19fe5c3e7a16eb34fdf78e5ff0ed706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327144 Reviewed-by: Daniel Ng <danielng@google.com> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/main@{#951961}

Roll Chrome Win32 PGO profile from chrome-win32-main-1639558498-bfc8cbd53a95441e4b362960336fa324f065b029.profdata to chrome-win32-main-1639569614-95b758b6040b003c163872523f690d81e16cfff4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I12fb76ebcfbeac1422afdcb7aa44e961509288e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341836 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951962}

This CL adds UserIsInDeveloperMode metric for the devtools API. The metric is added for all extensions except the ones installed by the enterprise policy and component extensions. Bug: 1267489 Change-Id: I10ecd41091bd67b26117eb81239c9546195d3d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3312894 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> Cr-Commit-Position: refs/heads/main@{#951963}

The InputMappingView was not properly deleted when removed. Changing to the correct RemoveChildT() function takes back ownership and deletes the view properly. The leak was discovered with lsan when running the DisplayOverlayControllerTest. Bug: 1278965 Change-Id: I53828549f537c772bb9045285f21f6141ff64368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339188 Auto-Submit: Addison Luh <aluh@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951964}

Logs time it takes for the GATT connection to reach a success. Change-Id: I2a0761a9d5a8596fc2e2d4cf41f15b2cc7a0e69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321993 Reviewed-by: Shane Fitzpatrick <shanefitz@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/main@{#951965}

Version Changes: tflite: aa79adb41c2f60c81d5d46d994c061abab686bb1 to dd57f5328f37a81197b0dadd052e05c9d9461b16 Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-compile-rel Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Cq-Include-Trybots: luci.chromium.try:android_arm64_dbg_recipe Cq-Include-Trybots: luci.chromium.try:android_compile_x64_dbg Cq-Include-Trybots: luci.chromium.try:android-pie-arm64-dbg Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng Change-Id: I769b568d37eebe1cbe6c8ac7d3b6d73b0ee20763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338086 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#951966}

If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/rts-linux-amd64-chromium-autoroll Please CC guterman@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: guterman@google.com Change-Id: If32501c557a56c7158ae85320c4838c29a52f1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341774 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951967}

This reverts commit fd041bd. Reason for revert: causes test failures https://crbug.com/1280303 Original change's description: > [Autofill Assistant] Enable animations + Remove filter > > In crrev/c/3309117 we disabled the tests for the "emulator_p". > This change reverts this and force-enables animations. > > Note: It is unclear why this is required - it should not be. > Tests are really flaky (or totally broken) without. > > Warning: This has the potential to make the builder(s) flaky > again. Revert in case of doubt. > > Bug: 1272997 > Bug: b/208965862 > Change-Id: I5cd3f01592c80f0ed942face42d4904c6f769f36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338359 > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Luca Hunkeler <hluca@google.com> > Commit-Queue: Sandro Maggi <sandromaggi@google.com> > Cr-Commit-Position: refs/heads/main@{#951857} Bug: 1272997, 1280303 Bug: b/208965862 Change-Id: Ib40f6466897b8212726a69f02e5a3cabbf6b448d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341525 Owners-Override: Alex Ilin <alexilin@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#951968}

Change-Id: Iea171a5bfa3fb441e44e8b08f06a0936481e2e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334121 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951969}

Using wpt-import in Chromium dd7cb63. With Chromium commits locally applied on WPT: 6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies" 7cd9af9 "Always assume that non-auto 'columns' might create a multicol." 004daf6 "[Sheriff] Undo 'standalone' for blocklisted-service-in-filter" 7b2fc96 "Allow empty CSS custom properties values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Ib93dda5420f946756117761f5f21dc152089cc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341634 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951970}

This was necessary for extension logic in the function, which has since been removed. Bug: 1209417 Change-Id: I637943a8d8335346037b8bf5a727653deada7ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339383 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charles Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951971}

https://android.googlesource.com/platform/external/perfetto.git/+log/f9abf9948a18..22467673a50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8eb1baf6cfb4bdce7d195b2d82b2326cd21cf824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342066 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951972}

Automatic update for 2021-12-15 UTC Change-Id: Ic38dc48111bc445fd0a6762b89e91b5c01f6b549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341095 Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Cr-Commit-Position: refs/heads/main@{#951973}

Bug: 212374 Change-Id: I0b14681d28438eaba7fc42743636f61e1b97cd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306459 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#951974}

With MPArch, the page url is supposed to be retrieved from RenderFrameHost->GetMainFrame(), rather than from its owning WebContents instance. Bug: 1277953 Change-Id: Ia129c4b194b2a6b1b10bf5770ca2a1439ea94351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323032 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Glen Robertson <glenrob@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@igalia.com> Cr-Commit-Position: refs/heads/main@{#951975}

This test disables the following tests that are flakily fail on Android M bots: - TabSuggestionMessageCardTest#groupTabSuggestionReviewedAndAccepted - TabSuggestionMessageCardTest#closeTabSuggestionReviewedAndDismissed Bug: 1273142, 1280257 Change-Id: I54f9aecc09879ba619d1cf7c09fd8855c8c19e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341555 Owners-Override: Alex Ilin <alexilin@google.com> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#951976}

If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I47e0648d5e161393ac9680ffbe50d54c38cd1717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341773 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951977}

The test is still failing on Marshmallow 64 bit Tester. Bug: 1269017 Change-Id: Idcae10390805801afcba46e67cd6fec853c3aa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327867 Quick-Run: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/main@{#951978}

These experiments target <=M96 so can now be removed from the config at head. Fixed: 1232625 Change-Id: I8805578393c2f780b14493ca5fe60ef49b2a5546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341318 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/main@{#951979}

It was disabled for flake on the sanitizer bots. Re-enable it on other bots. Do some incidental cleanup. Delete the test OpenBrowserUsingContextMenu. This test provides little additional value now that we're running the shelf item test. Bug: 1038342 Test: browser_tests Change-Id: I20850bf1d26d09ecf0ff391898f90190bc3b34b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341384 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#951980}

This test has started frequently failing following the landing of https://chromium-review.googlesource.com/c/chromium/src/+/3329602/. That CL is not suitable for immediate revert as it was landed on trunk, 98, and 97 to investigate whether the behavior that it is undoing was the cause of a significant startup performance regression. I am investigating the reason for the increased flake of this test, but in the meantime, this CL disables it to avoid the flake causing problems for others. Bug: 1280192 Change-Id: I69bf1346f516abb54c901955fab156306d0a3910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341464 Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#951981}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b47975a82916..d692cac31ffe 2021-12-15 aerotwist@chromium.org Remove patchColorText usage in NetworkWaterfallColumn 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/timeline/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/settings/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/elements/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/network/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class fields in panels/issues/components/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1222126,chromium:1278738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iee6b9f009eebca09b56666aa866553978aa00066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341413 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951982}

Preparation for being able to do palette string to index resolutions required for font-palette and @font-palette-values support. Bug: 1170794 Change-Id: I43eaeed78ed37f1ef18f7c6f5d58a1e291042617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340943 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#951983}

Bug: 1279835 Change-Id: I67e72c8871338e7b025089bfab0a88602a7917dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341179 Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951984}

Chrome-wide audio mixing: When the last listener is gone but there are active tracks, the switch to unmixed playback is scheduled. Meanwhile, all tracks may be gone. In that case we want to stop mixing immediately. (Otherwise next track to come may be started as a mixed playback for no good reason, and then switched to unmixed playback shortly after when the timer runs out, - which would cause an unnecessary glitch.) Bug: 1279802, 1224845 Change-Id: Ic524492a528e6feb611970de6642a5c31bc674e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341322 Reviewed-by: Sam Zackrisson <saza@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/main@{#951985}

NGInlineItemsBuilderTemplate::ExitInline() has a special rule for AREA elements, and we need to respond on that during pre-paint, so that they are visited (and get their invalidation flags cleared). Note that this doesn't fix the original fuzzer in crbug.com/1279525 Bug: 1279525 Change-Id: Ib05b4cc3eebff85fc5e2999b1f90d16d75bf36f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341320 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951986}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f13e5c5ff2d..1cad40c1e720 2021-12-15 cmfcmf@chromium.org dependency: convert docstring types to typing hints 2021-12-15 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-15 cmfcmf@chromium.org payload: convert docstring types to typing hints 2021-12-15 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-15 yoshiki@google.com Collect goma logs on failure of BuildPackage 2021-12-15 yueherngl@google.com brya: enable hw_tests 2021-12-15 kimjae@chromium.org gs: google storage Stat() retry throws GSNoSuchKey 2021-12-15 shaochuan@chromium.org android: implement WriteLKGB endpoint 2021-12-15 shaochuan@chromium.org api: sync protos 2021-12-15 shaochuan@chromium.org android: canonical way to retrieve Android package dir 2021-12-15 rickytlchang@google.com draco: add factory/recovery signing and disable HW test 2021-12-14 vapier@chromium.org cros ap: add framework for registering subcommands 2021-12-14 cmfcmf@chromium.org sdk: convert docstring types to typing hints 2021-12-14 zland@google.com lib: Remove COIL terms from perf_uploader & refs 2021-12-14 zland@google.com lib: Remove COIL terms from uri_lib and references 2021-12-14 zland@google.com Remove COIL terms from osutils and references 2021-12-14 vapier@chromium.org cros uprevchrome: drop deprecated command 2021-12-14 vapier@chromium.org change ~/trunk to ~/chromiumos 2021-12-14 juahurta@google.com config: Disable unittests on skyrim-release 2021-12-14 latware@google.com Enabling build of callbox server. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2d557fbc482dca2530887594441de62295ce0926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342086 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951987}

Iif AutofillDelayPopupControllerDeletion is enabled, AutofillPopupControllerImpl deletes itself in a separate task. Before this CL, to cancel a pending deletion in GetOrCreate(), we invalidated the WeakPtrs. This also included WeakPtrs in AutofillPopupViewNativeViews which should not have been invalidated. Instead of invalidating WeakPtrs, this CL cancels the deletion task. Bug: 1280027, 1279971, 1280009 Change-Id: Ibdcc73cc392bb00732f72ac592c88e8940866b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340941 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#951988}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202112150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/27KUeowb-avScJevs9PyckybR1s34lIOg_CMEaolREQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ibc79e3e1d9a4ea21b576a71d4021abb48653eebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341777 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951989}

When calculated AXSelectedChildren, AXSelected was not respected on the child for the non-multiselect case. This fix ensures the child is selected before returning it, which successfully keeps "selected" from being voiced by VoiceOver when navigating to a button. Bug: 1276763 Change-Id: I4c52e56a7170c940ee06e4bf1cd8bb8c63244f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335616 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#951990}

The fuzzer found a null-dereference error in Element::Blur that was introduced by one of my change a while back. This CL fixes it. Bug: 1278752 Change-Id: I0eb0930c5cc2c4ea2f8350d5f873f86bc593ab01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339916 Reviewed-by: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951991}

The enum name was used instead of the histogram name. Bug: 1280309 Change-Id: Ia4fccf40393abfccd4c852af98f05a2633c2c8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341524 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/main@{#951992}

This removes nonsfi support from NaCl's chrome IPC. Also, it removes nonsfi flag from NexeLoadManager. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I5bc9376ccf270dbe5d86cf8884a9c0dccef25b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341092 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Derek Schuff <dschuff@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951993}

The test `external/wpt/referrer-policy/gen/srcdoc.meta/strict-origin/iframe-tag.http.html` started failing on Mac a short while ago. Of course it passes for me locally, and I have no good ideas as to how to fix this, so I'm going to start by re-enabling to see if I can reproduce it that way. R=hiroshige@chromium.org Bug: 1264753 Change-Id: Ib93719803a7c2131794d50d6cd55816f80d1fba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341636 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#951994}

This change adds logic to HostResolverManager to use pre-configured IP addresses for the initial connection to a DoH server. If a bootstrap IP is used, the resolver also starts an asynchronous followup request to ask the DoH server for its own IP address, which will be used for subsequent connections. This change does not add the ability to store any bootstrap IPs, so this logic is not yet live. Bug: 1200908 Change-Id: Iab4bf7344b59e042a9bdaa944ec5ac7c1ff2f35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193799 Reviewed-by: Eric Orth <ericorth@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951995}

If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I24540b55e0e6b772f2acb7dfade57c9199cf6321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341771 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951996}

(xcode13 requires Mac OS 11) Bug: b/210105045 Change-Id: I5f45432254babd653ecd25332c51a1c766cdb51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341551 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Björn Terelius <terelius@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#951997}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] main from chromium:main #116

[pull] main from chromium:main #116

Commits on Dec 15, 2021