[pull] main from chromium:main #115
Merged
Commits on Dec 15, 2021
-
[mparch] Add a test for the permission request for a fenced frame
This CL introduces a test that the permission request is blocked in a fenced frame when it's requested through PermissionControllerDelegate. Bug: 1275979 Change-Id: I98d8c71b1c3ef1a274993e813e87439deafd2af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329645 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/main@{#951827}
-
[Snooping protection] Replaced outdated radio list with a toggle.
The UX for the snooping detection feature has evolved to always display an eye icon and optionally hide notifications when a snooper is detected. This CL both adds the (currently-unused) preference needed to control notification behavior, and also updates the settings UI to reflect the new UX. Added / updated strings shouldn't be translated as they are still not final. Bug: chromium:1276903 Change-Id: I3da07e4b72d5e1966bd3850acfa6a7ee9d8a69ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334237 Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951828}
-
[Sensors] AmbientLightSensor rounding moved to browser process
Currently illuminance rounding is done in Blink, but all other sensors rounding is done in browser process. At first it was thought to be useful to provide raw, non-quantized data from the browser process in case other consumers needed it, but given there don't seem to be any other consumers all rounding operation is now done in the browser process. Due to crbug.com/1278377 bug and because we use JS mocks for Sensor and SensorProvider in the web tests we can no longer test the rounding in web tests, and consequently we can also drop the custom AmbientLightSensor.https.html from wpt_internal. Bug: 1196238 Change-Id: I6cb87fcf6db4d7cb32410d36df6de20d1542200d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320228 Reviewed-by: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Juha J Vainio <juha.j.vainio@intel.com> Cr-Commit-Position: refs/heads/main@{#951832}
-
Fix test expectation and baseline to unblock wpt importer
Change-Id: I4260c52c77ce0ae23ab99b8b5e4a1adfa8e3d829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340245 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Weizhong Xia <weizhong@google.com> Cr-Commit-Position: refs/heads/main@{#951834}
-
[skylab_tests] Update skylab tests cros img version
This CL will update cros image version for skylab tests. CROS_BOARD_LKGM is updated according to chromeos/CHROMEOS_LKGM; CROS_BOARD_DEV, CROS_BOARD_BETA and CROS_BOARD_STABLE are updated according to Omaha. If this CL caused regressions, please revert and pause the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-skylab-tests-cros-img-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Change-Id: Ib3cf276c39d35a8618673289df751a65ed20059b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339283 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/main@{#951835}
-
[mparch] Use PrimaryPageChanged in SameOriginObserver.
This CL replaces DidFinishNavigation with PrimaryPageChanged in SameOriginObserver and adds a fenced frame test. The same-origin state should not be changed by the non-primary navigations. Bug: 1274485 Change-Id: I79ebb33dc371bfbf871f6299b0c2a2d50a92ae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3305967 Reviewed-by: Kevin McNee <mcnee@chromium.org> Reviewed-by: Elad Alon <eladalon@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Hyowon Kim <hyowon@igalia.com> Cr-Commit-Position: refs/heads/main@{#951837}
-
Remove dead files chromeos/login/auth/login_event_recorder.{cc|h}
This CL removes dead files chromeos/login/auth/login_event_recorder.{cc|h}, since these were removed from BUILD.gn by https://crrev.com/c/3003986. Change-Id: Iccd4cf4c00f240d36771b1e61c6fe306b174563a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337886 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yeunjoo Choi <ychoi@igalia.com> Cr-Commit-Position: refs/heads/main@{#951843} -
Roll src/third_party/cros_system_api/ 48bb7e747..725259a4b (12 commits)
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/48bb7e7474f0..725259a4bd76 $ git log 48bb7e747..725259a4b --date=short --no-merges --format='%ad %ae %s' 2021-12-10 ayaelattar system_api: Update dlp service protos 2021-11-19 thomascedeno cryptohome: Implementation for ExtendAuthSession Dbus 2021-11-13 dlunev cryptohome: Remove support for rename 2021-09-22 pdk system_api: Introduce FingerprintMessage protobuf 2021-12-07 charleszhao hps: add HpsResultProto for hps dbus. 2021-11-11 kimjae system_api: Add update_engine toggle feature constant 2021-12-05 genechang rmad: Change index type of region/sku/WL list from unsigned to int 2021-11-23 dlunev cryptohome: Add dbus and CLI endpoints for new mount calls. 2021-11-18 dlunev cryptohome: add UDA handlers for direct Mount ops 2021-11-30 jthies typecd: Send notification on invalid dp cable 2021-11-18 genechang system_api: rmad: Add proto for state transition in sensor calibration 2021-11-21 charleszhao hps: Add average filter and tristate. Created with: roll-dep src/third_party/cros_system_api Bug: 1259203 Change-Id: Idef8be17f6a8f7f57d49869be417fc5b4b3605ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329892 Reviewed-by: Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/main@{#951847}
-
Lacros web apps: Icons for App Management completed in Ash
AppIconLoader::CompleteWithIconValue() is now public. For Lacros web apps, WebAppsCrosapi in Ash applies effects and then calls CompleteWithIconValue(). WebAppsPublisherHost in Lacros now generates uncompressed icons instead of compressed icons. App Management now shows icons for Lacros web apps. Bug: 1259812 Change-Id: I5453c5cbbf950a7f14980c25741236ccc3ab96f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338539 Reviewed-by: Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/main@{#951848}
-
Previously, in crrev.com/c/3284803, the argument for HitTestLocation was replaced the position in root frame. However, the previous ViewportToFrame first converts to position in root frame, and then converts again by calling ConvertFromRootFrame. The second conversion was missing and is restored here. R=dtapuska@chromium.org Fixed: 1279717 Change-Id: I80094c55472dae5242fbca035469ab44fa38f6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338358 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951851}
-
Clean up ServiceWorker.OfflineCapable.Reason* and callers of it
This CL marks ServiceWorker.OfflineCapable.Reason* with Obsolete and removes the callers of the metric. The metric is used for the CheckOfflineCapability feature but the development of the feature is suspended and we don't have immediate plan to re-start it. Bug: 1272726 Change-Id: I653f75e0623f95ee9418fe4c7e10624c16260166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3337198 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#951852}
-
CrOS: Migrate chrome://sys-internals to JS modules.
Bug: 1173575 Change-Id: Ib93264e69d8fe898f69c363466bb63538f1e1e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3334988 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/main@{#951856}
-
[iOS] Update CPE's 'Add password' view footer
This CL updates existing footer text. Sync: https://drive.google.com/file/d/1aGlAjqRjnvtRLvuCbQ5D94JUF-vv4fQR/view?usp=sharing&resourcekey=0-6s_RlBQmLDm47Jz47Geijg Not sync: https://drive.google.com/file/d/14nn6gvp0ntXmjxjeYOL8INUt4AbU0yC0/view?usp=sharing&resourcekey=0-h6agkVyweBfg29k3RtR8vQ Dynamic: https://drive.google.com/file/d/1Jf0nspxawmw46Br_j54jrWB4p4qPjvTo/view?usp=sharing&resourcekey=0-bvX-4T5rKMAEQEJp4D235w Fixed: 1268777 Change-Id: I1dcd2137d7dd67972dd5e944d6d3de93073580a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317579 Reviewed-by: Robbie Gibson <rkgibson@google.com> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#951862}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.