Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from chromium:main #110

Merged
merged 51 commits into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
5d62b1f
[ChromeOS] Add raleksandrov@ as an owner c/b/ui/webui/chromeos/login
Dec 14, 2021
83681fe
Roll Chrome Win32 PGO Profile
Dec 14, 2021
3493ce7
Roll ChromeOS Atom AFDO profile from 98-4729.0-1638787322-benchmark-9…
Dec 14, 2021
94cdce4
Disable ContextualSearchTest#testTextTapFollowedByNonTextTap.
mvano Dec 14, 2021
bed0396
Sherrif: Disable failing Linux TSan test
sreejakshetty Dec 14, 2021
d8756ae
Roll Projector App from GNNkSm3f-... to FchxTKMvf...
Dec 14, 2021
9c9a227
Roll AFDO from 98.0.4758.5_rc-r1-merged to 98.0.4758.7_rc-r1-merged
Dec 14, 2021
8e6a6b8
ozone/wayland: make IME work without keyboard
Dec 14, 2021
5441f9b
Update WebUI JS code naming to reflect the Profile::IsChild API.
Dec 14, 2021
78a96dc
OOBE: Handle Guest ToS screen in browsertests
Dec 14, 2021
9e2430b
Fix use-after-move in AccessTokenFetcher
Dec 14, 2021
c42d733
[Autofill Assistant] Remove ActivityType Chrome dependency
Dec 14, 2021
0a250d4
Revert "[Windows] Remove duplicate use of NtQueryObject."
Dec 14, 2021
293ef66
[Passwords] Fix assertion failure when opening password settings
Dec 14, 2021
50788d8
Record Metal ReadWrite texture UMA histogram.
Kangz Dec 14, 2021
23dd95c
FLEDGE: support bidding_wasm_helper_url in InterestGroupStorage
Dec 14, 2021
4d4e7b1
FLEDGE: Teach AuctionUrlLoaderFactoryProxy about WASM
Dec 14, 2021
263346f
[Frameworks roll] Roll to 416225180 piper revision
Dec 14, 2021
5d7c602
Revert "Add remaining html accessibility static tree tests on Android"
mvano Dec 14, 2021
58bf84b
Roll Chrome Win64 PGO Profile
Dec 14, 2021
7fe1757
Enable Advertisement Monitoring by default.
Dec 14, 2021
000ce14
Fix typo (immedately -> immediately) in comments
dsanders11 Dec 14, 2021
8fe6ed3
Import wpt@5f97bc75226f65d50f57938297a2a86d0c38cdb0
Dec 14, 2021
c410374
Disable flaky part of PowerBookmarkTest.
mvano Dec 14, 2021
c4d13b5
[WPT] Assign bug id to wpt/scroll-animations tests
schenney-chromium Dec 14, 2021
4cad683
DevTools: refresh nodes on AXObjectModified
johanbay Dec 14, 2021
c603d5f
Roll DevTools Frontend from a84185e6b5be to a1121f966ce5 (1 revision)
Dec 14, 2021
94219c0
Handle token update in AccountAppsAvailability
Dec 14, 2021
f8b6e08
[Nearby] Add background scanning metrics
Dec 14, 2021
d792570
Roll Chrome Mac PGO Profile
Dec 14, 2021
5ed2255
[Android] Move ChromeVersionInfo to /components
Dec 14, 2021
5c49cdc
Remove unnecessary header.
Dec 14, 2021
0ab5e3d
Roll Fuchsia SDK from 7.20211213.3.1 to 7.20211214.1.1
Dec 14, 2021
ae6958a
Roll Chrome Linux PGO Profile
Dec 14, 2021
ff2e07d
Refactor FakeContentCaptureSender.
hyowon-igalia Dec 14, 2021
d3fa2c8
Fenced Frames: urn:uuid should be in RFC-4122 format
Dec 14, 2021
851f0a5
Updating XTBs based on .GRDs from branch main
Dec 14, 2021
5202af8
[LayoutNGPrinting] First prototype for printing with LayoutNG.
mstensho Dec 14, 2021
9fe08eb
Add a flag to enable forcing the User-Agent minor version to 100
abeyad Dec 14, 2021
509ea5f
Disable flaky parts of AwAutofillTest.
mvano Dec 14, 2021
2a89baa
[Telemetry] Fix CanOverridePwaOriginForTesting
Dec 14, 2021
7284f68
Roll Catapult from 1ba82f650c64 to e3f9ae73db51 (1 revision)
Dec 14, 2021
b23c593
Roll Fuchsia Internal SDK from 7.20211213.3.2 to 7.20211214.1.1
Dec 14, 2021
75505f3
ash: Cache the app list bubble widget for productivity launcher
Dec 14, 2021
d139fda
[ChromeOS][OOBE] Remove mentions of md_screen_container.css
Dec 14, 2021
010d67f
Actual version update for material design to 1.6.0-alpha01.
Dec 14, 2021
a0d01ec
dlp: Rename DlpContentManager -> DlpContentManagerAsh
Dec 14, 2021
4184d58
Update API level for Android-12L from Sv2 to 32 for sdk-packager
Dec 14, 2021
67725fd
Android: Ensure multiprocessing pool is close in jni_registration_gen…
agrieve Dec 14, 2021
1252f7e
Roll Chrome Win32 PGO Profile
Dec 14, 2021
fe4e8ad
Updater: eliminate sleeps in integration tests.
Dec 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 5 additions & 5 deletions DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -306,15 +306,15 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling catapult
# and whatever else without interference from each other.
'catapult_revision': '1ba82f650c64340d5f581522efa511ceea415c0b',
'catapult_revision': 'e3f9ae73db5135ad998108113af7ef82a47efc51',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling libFuzzer
# and whatever else without interference from each other.
'libfuzzer_revision': 'debe7d2d1982e540fbd6bd78604bf001753f9e74',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling devtools-frontend
# and whatever else without interference from each other.
'devtools_frontend_revision': 'a84185e6b5be9c88f8aad0fa589ab7c213d77e5d',
'devtools_frontend_revision': 'a1121f966ce5590b46706befdf60e3350a5cf2d1',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling libprotobuf-mutator
# and whatever else without interference from each other.
Expand Down Expand Up @@ -635,7 +635,7 @@ deps = {
},

'src/ios/third_party/material_components_ios/src': {
'url': Var('chromium_git') + '/external/github.com/material-components/material-components-ios.git' + '@' + 'fc61c312d9bd1650f8bb558359c3e179900bc94d',
'url': Var('chromium_git') + '/external/github.com/material-components/material-components-ios.git' + '@' + 'fae0808b93a28b00796cdf10d3f50e16aaf2d71e',
'condition': 'checkout_ios',
},

Expand Down Expand Up @@ -1741,7 +1741,7 @@ deps = {
'packages': [
{
'package': 'chromeos_internal/apps/projector_app/app',
'version': 'GNNkSm3f-_u5XLEkNk_gDIcdzAc9jLL9kkDHNH94I1kC',
'version': 'FchxTKMvfxSkGTLMU23cSyqvexH52wHP-zPlLYF6QqUC',
},
],
'condition': 'checkout_chromeos and checkout_src_internal',
Expand Down Expand Up @@ -2543,7 +2543,7 @@ deps = {
'packages': [
{
'package': 'chromium/third_party/android_deps/libs/com_google_android_material_material',
'version': 'version:2@1.5.0-alpha05.cr0',
'version': 'version:2@1.6.0-alpha01.cr0',
},
],
'condition': 'checkout_android',
Expand Down
2 changes: 1 addition & 1 deletion android_webview/browser/aw_content_browser_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ bool AwContentBrowserClient::CanCreateWindow(

base::FilePath AwContentBrowserClient::GetDefaultDownloadDirectory() {
// Android WebView does not currently use the Chromium downloads system.
// Download requests are cancelled immedately when recognized; see
// Download requests are cancelled immediately when recognized; see
// AwResourceDispatcherHost::CreateResourceHandlerForDownload. However the
// download system still tries to start up and calls this before recognizing
// the request has been cancelled.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ private ProductionSupportedFlagList() {}
+ " PageTimeSpent."),
Flag.baseFeature(BlinkFeatures.FORCE_MAJOR_VERSION100_IN_USER_AGENT,
"Force the Chrome major version number to 100 in the User-Agent string."),
Flag.baseFeature(BlinkFeatures.FORCE_MINOR_VERSION100_IN_USER_AGENT,
"Force the Chrome minor version number to 100 in the User-Agent string."),
Flag.baseFeature(NetworkServiceFeatures.URL_LOADER_SYNC_CLIENT,
"Optimizes communication between URLLoader and CorsURLLoader."),
Flag.baseFeature(BlinkFeatures.SET_TIMEOUT_WITHOUT_CLAMP,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,7 @@ public void tearDown() {
@Test
@SmallTest
@Feature({"AndroidWebView"})
@DisabledTest(message = "https://crbug.com/1279813")
public void testTouchingFormWithAdjustResize() throws Throwable {
PostTask.runOrPostTask(UiThreadTaskTraits.DEFAULT, () -> {
mRule.getActivity().getWindow().setSoftInputMode(
Expand Down Expand Up @@ -1146,6 +1147,7 @@ public void testAutofillTriggersAfterReload() throws Throwable {
@Test
@SmallTest
@Feature({"AndroidWebView"})
@DisabledTest(message = "https://crbug.com/1279813")
public void testNotifyVirtualValueChanged() throws Throwable {
final String data = "<html><head></head><body><form action='a.html' name='formname'>"
+ "<input type='text' id='text1' name='username'"
Expand Down Expand Up @@ -1180,6 +1182,7 @@ public void testNotifyVirtualValueChanged() throws Throwable {
@Test
@SmallTest
@Feature({"AndroidWebView"})
@DisabledTest(message = "https://crbug.com/1279813")
public void testJavascriptNotTriggerNotifyVirtualValueChanged() throws Throwable {
final String data = "<html><head></head><body><form action='a.html' name='formname'>"
+ "<input type='text' id='text1' name='username'"
Expand Down Expand Up @@ -1304,6 +1307,7 @@ public void testMovingToOtherForm() throws Throwable {
@Test
@SmallTest
@Feature({"AndroidWebView"})
@DisabledTest(message = "https://crbug.com/1279813")
public void testSwitchFromIFrame() throws Throwable {
// we intentionally load main frame and iframe from the same URL and make both have the
// similar form, so the new session is triggered by frame change
Expand Down Expand Up @@ -1518,6 +1522,7 @@ public void testNoSubmissionWithoutFillingForm() throws Throwable {
@Feature({"AndroidWebView"})
@DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.P,
message = "This test is disabled on Android O because of https://crbug.com/997362")
@DisabledTest(message = "https://crbug.com/1279813")
public void
testSelectControlChangeNotification() throws Throwable {
int cnt = 0;
Expand Down Expand Up @@ -2053,6 +2058,7 @@ public void testUMAAutofillCreatedByActivityContext() {
@Test
@SmallTest
@Feature({"AndroidWebView"})
@DisabledTest(message = "https://crbug.com/1279813")
public void testPageScrollTriggerViewExitAndEnter() throws Throwable {
final String data = "<html><head></head><body><form action='a.html' name='formname'>"
+ "<input type='text' id='text1' name='username'"
Expand Down Expand Up @@ -2672,6 +2678,7 @@ public void testFieldAddedBeforeSuggestionSelected() throws Throwable {
@Test
@SmallTest
@Feature({"AndroidWebView"})
@DisabledTest(message = "https://crbug.com/1279813")
public void testFirstFieldRemovedBeforeSuggestionSelected() throws Throwable {
// This test verifies that form filling works even if an element of the form that was
// supposed to be filled has been deleted between the time of decision to fill the form and
Expand Down
15 changes: 10 additions & 5 deletions ash/app_list/app_list_bubble_event_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ AppListBubbleEventFilter::AppListBubbleEventFilter(
base::RepeatingCallback<void()> on_click_outside)
: widget_(widget), button_(button), on_click_outside_(on_click_outside) {
DCHECK(widget_);
DCHECK(button_);
DCHECK(on_click_outside_);
Shell::Get()->AddPreTargetHandler(this);
}
Expand All @@ -30,6 +29,10 @@ AppListBubbleEventFilter::~AppListBubbleEventFilter() {
Shell::Get()->RemovePreTargetHandler(this);
}

void AppListBubbleEventFilter::SetButton(views::View* button) {
button_ = button;
}

void AppListBubbleEventFilter::OnMouseEvent(ui::MouseEvent* event) {
if (event->type() == ui::ET_MOUSE_PRESSED)
ProcessPressedEvent(*event);
Expand All @@ -56,10 +59,12 @@ void AppListBubbleEventFilter::ProcessPressedEvent(
// Ignore clicks that hit the button (which usually spawned the widget).
// Use HitTestPoint() because the shelf home button has a custom view targeter
// that handles clicks outside its bounds, like in the corner of the screen.
gfx::Point point_in_button = event_location;
views::View::ConvertPointFromScreen(button_, &point_in_button);
if (button_->HitTestPoint(point_in_button))
return;
if (button_) {
gfx::Point point_in_button = event_location;
views::View::ConvertPointFromScreen(button_, &point_in_button);
if (button_->HitTestPoint(point_in_button))
return;
}

on_click_outside_.Run();
}
Expand Down
6 changes: 5 additions & 1 deletion ash/app_list/app_list_bubble_event_filter.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ class ASH_EXPORT AppListBubbleEventFilter : public ui::EventHandler {
AppListBubbleEventFilter& operator=(const AppListBubbleEventFilter&) = delete;
~AppListBubbleEventFilter() override;

// Changes the button to check (see class comment). Useful if the app list
// has changed displays, so a different home button needs to be checked.
void SetButton(views::View* button);

// ui::EventHandler:
void OnMouseEvent(ui::MouseEvent* event) override;
void OnTouchEvent(ui::TouchEvent* event) override;
Expand All @@ -45,7 +49,7 @@ class ASH_EXPORT AppListBubbleEventFilter : public ui::EventHandler {
void ProcessPressedEvent(const ui::LocatedEvent& event);

views::Widget* const widget_;
views::View* const button_;
views::View* button_; // May be null.
base::RepeatingClosure on_click_outside_;
};

Expand Down
Loading