Utilized: Vector and angle Unpack metamethods inutil.TypeToString

[dvdvideo1234]

No description provided.

[thegrb93]

Have you timed it? I would say that this is theoretically faster.

[Kefta]

Unpack is much faster.

local vindex
local unpack

do
	local VECTOR = FindMetaTable("Vector")
	vindex = VECTOR.__index
	unpack = VECTOR.Unpack
end

local v = Vector(1, 2, 3)

local function pt(a, b, c)
end

local start = SysTime()

for i = 1, 10000000 do
	pt(vindex(v, 1), vindex(v, 2), vindex(v, 3))
end

print("numeric index", SysTime() - start)

local start = SysTime()

for i = 1, 10000000 do
	pt(vindex(v, "x"), vindex(v, "y"), vindex(v, "z"))
end

print("string index", SysTime() - start)

local start = SysTime()

for i = 1, 10000000 do
	pt(unpack(v))
end

print("unpack", SysTime() - start)

numeric index	4.4967768
string index	4.5139108
unpack	0.8396242

[Kefta]

It's using Vector:Unpack which is a metatable function, not related to Lua's unpack.

[GrahamBest]

Unpack is definitely much faster. I don't see much point in this PR honestly.

These PRs with simple coding style changes just to "change it" make no sense. Common sense and @Kefta performance test show Unpack is much superior.

[Kefta]

@verideth His primary change is to add angle support to util.TypeToString. The Unpack change is just a bonus.

[robotboy655]

In hindsight this was a very pointless change, all it essentially does is remove 1 decimal point compared to Angle's tostring()

[Kefta]

The function should probably just be deprecated.