fix EntityInteractCallback not reaching server if canceled on client #139
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #135
This changes the cancelation of the injected method to happen after the
ServerboundInteractPacket
has been send to the server instead of before. This means that returning a non-nullInteractionResult
on client now still triggers theEntityInteractCallback
on the server too instead of omitting it.I have also added an example callback to the test mod to check if this actually solves the issue, I have left it in, but can also remove it again if you want to.