25w10a fixes #4150
Merged
25w10a fixes #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`grep --recursive -E "static final [^ ]* ([a-eg-z]|f[^i]|fi[^e]|fie[^l])"` (note that this also catches false positives such as `? extends` in types)
Resolves FabricMC#3757 Resolves FabricMC#3911 Resolves FabricMC#4131 Resolves FabricMC#4132
Shnupbups
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3757
Resolves #3911
Resolves #4131
Resolves #4132
Also fixes javadoc issues, etc.
I also want to re-check the contents of javadoc at some point.