Improve MemoryMappingTree merging capabilities
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix issue 68 - Make the pending member queue fully functional (both for missing src names and descriptors) - Extend pending feature to classes - Enable incoming data to have inverted namespaces - Delay descriptor computation until `visitEnd`, so all potentially referenced classes are available - Fix `MemoryMappingTree#reset` to actually reset all its internal state related to the current visitation pass - Add basic protection against external data modification while visitation pass is in progress - Clarify API contracts regarding returned collections' mutability
|
ah i was running into this issue just today |
modmuss50
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visitEnd, so all potentially referenced classes are availableMemoryMappingTree#resetto actually reset all its internal state related to the current visitation pass