-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement built-in mod resource pack sorting #3913
Conversation
This should be on the |
Why, exactly? This is just for ordering inside of the |
This is a great start, but I think we need to come up with a concreate plan for what we want. I see a few problems with the current approach of only allowing entire mods to be lower or higher. I think this is going to cause issues where mods just put them selves higher for the sake of it, just moving the problem elsewhere. Being able to specify their relation with specific mod ids might be a better solution? e.g higher than I agree it does seem strange to have this in the fmj, although im not going to outright dismiss it. If it was in the packmc.meta could it allow sorting builtin packs diffrently? The meta file already contains the conditions, it seems like a logicial place to put this. The split between the assets and data feels a little strange to me as well. |
* Add an API to add additional supported blocks to block entity types. (FabricMC#4009) (cherry picked from commit 40875a9) * Bump version * Add chorus fruit to 1c:foods/fruit` tag --------- Co-authored-by: modmuss <modmuss50@gmail.com>
* Crafter support for the transfer api. Closes FabricMC#4004 * Review feedback
* Add #c:nuggets/iron and #c:nuggets/gold Closes FabricMC#4005. * Add crop item tags Everything but c:crops/cocoa_bean is already in NeoForge. * Add more crop tags and documentation for #c:crops
* New translations en_us.json (Chinese Simplified) * New translations en_us.json (German) * New translations en_us.json (Italian)
Screwed up some Github thing, creating fresh PR to fix it. |
Overriding data/resource pack files from other mods is currently quite difficult as mod loading order isn't consistent. This can be especially annoying for compatibility mods that exist to override data/resource files from other mods.
This PR addresses the issue by implementing a system for mods to define in their
fabric.mod.json
what their priority is in the internal Fabric Mods data/resource pack. There are five phases, with each occuring in a deterministic order (intra-phase sorting isn't guaranteed). These phases are currentlybottom
,lower
,default
,upper
, andtop
but can be changed if there is a better naming convention.Mods that wish to change their priority in the load order can add this to their
fabric.mod.json
file: