Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected Interfaces Expansion => Generics Support #1050

Merged

Conversation

FirstMegaGame4
Copy link
Contributor

@FirstMegaGame4 FirstMegaGame4 commented Feb 18, 2024

Before this pull request, modders were able to add injected interfaces in other classes, but they were not able to use generics for them. This pull request allows to specify the raw generics signature (which is a part of the ClassSignature) after the interface name in fabric.mod.json, solving the issue.

Examples:

Before:

"net/minecraft/class_x": [
    "com/example/WithoutGenerics",
    "com/example/WithGenerics" // but we can't specify them
]

After:

"net/minecraft/class_x": [
    "com/example/WithoutGenerics",
    "com/example/WithGenerics<Ljava/lang/String;>"
]

Fixes #597

@modmuss50 modmuss50 added this to the 1.6 milestone Feb 19, 2024
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start 👍

Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, seems to be struggling to build though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants