Add file extensions to open and save dialogs #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
changed the title
…gration Merge upstream
Juuxel
force-pushed
the
mapping-file-extensions
branch
from
56b9da3
to
a8cf4e0
Compare
NebelNidas
approved these changes
Apr 6, 2024
modmuss50
approved these changes
Apr 6, 2024
ix0rai
added a commit
to ix0rai/enigma
that referenced
this pull request
Apr 16, 2024
ix0rai
added a commit
to QuiltMC/enigma
that referenced
this pull request
Jun 3, 2024
* FabricMC/Enigma#532 - rai version * fix ExtensionFileFilter for leading dot change * checkstyle * oro review + filter "open" dialogue * start moving to plugin * migration to read write service: begin! * add namespace parameters to MappingSaveParameters, port most of command * add non functional activeByDefault parameter to service types, move DecompilerService * decompiler service active by default * implement active by default * cli tests passing! * core tests passing! * GUI compiles (does not work) * default to enigma format for directories * checkstyle * fix test checkstyle, remove bad API methods * add "tiny" extension for tiny format * more docs * add validation for plugin registration * update gradle * checkstyle * address gradle deprecation * update gradle again, update proguard * fix gradle deprecations * actions should pass again * test plugin id validation * test all types of plugin validation * refactor test names * IN MY DOCUMENTATION ERA * fix some issues * reintroduce EnigmaServiceType.create * private tinyWriter constructor * improve MappingFileNameFormat docs * Update enigma/src/main/java/org/quiltmc/enigma/api/service/NameProposalService.java Co-authored-by: Iota <47987888+IotaBread@users.noreply.github.com> * Update enigma-cli/src/main/java/org/quiltmc/enigma/command/InvertMappingsCommand.java Co-authored-by: Iota <47987888+IotaBread@users.noreply.github.com> * Update enigma-cli/src/test/java/org/quiltmc/enigma/command/FillClassMappingsCommandTest.java Co-authored-by: Iota <47987888+IotaBread@users.noreply.github.com> * only create enigma instances once in commands * Update enigma-cli/src/test/java/org/quiltmc/enigma/command/MapSpecializedMethodsCommandTest.java Co-authored-by: Iota <47987888+IotaBread@users.noreply.github.com> * use WalkFileTree * superfluous variable in build.gradle * new default namespaces * reimplement format detection test (no longer automatic :( ) * checkstyle and NPE fix * test format not found * remove pointless method --------- Co-authored-by: Iota <47987888+IotaBread@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes about the extension choices:
.txtfor ProGuard comes from the ReTrace manual: "java -jar retrace.jar mapping.txt stacktrace.txt".txtfor Recaf mappings comes from Recaf's test code.mappingwas chosen as the extension for single Enigma files too (see Discord)ExtensionFileChooserwas written to be a bit more general than this PR needs it to be so that it can be used for e.g. the open JAR dialog in the future.Also fixes #533 by choosing Enigma directories as the default save format when closing.