Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float3/4.Normalize.Zero returns zero #481

Merged
merged 2 commits into from
May 4, 2022
Merged

float3/4.Normalize.Zero returns zero #481

merged 2 commits into from
May 4, 2022

Conversation

wrestledBearOnce
Copy link
Member

see #461

@wrestledBearOnce wrestledBearOnce linked an issue Apr 29, 2022 that may be closed by this pull request
float3/4.Normalize.Zero returns float3/4.NaN, should return float3/4.Zero #461
Closed
ASPePeX
ASPePeX reviewed May 2, 2022
View reviewed changes
Copy link
Member

@ASPePeX ASPePeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly intN.Normalize() to return a floatN, instead of a intN approximation, was deliberate. But it is as matter of definition and should be discussed at our next meeting.

@wrestledBearOnce
Copy link
Member Author

If I remember correctly intN.Normalize() to return a floatN, instead of a intN approximation, was deliberate. But it is as matter of definition and should be discussed at our next meeting.

imoh intN(1,1,1) should not normalize to intN(0,0,0) due to missing decimals.

@ASPePeX
Copy link
Member

ASPePeX commented May 2, 2022

I agree, that is why we didn't drop the decimal.

ASPePeX
ASPePeX approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@ASPePeX ASPePeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, didn't see the intX.Normalize() changes were reversed.

@wrestledBearOnce wrestledBearOnce merged commit e5da1c0 into develop May 4, 2022
@wrestledBearOnce wrestledBearOnce deleted the feature/461-fix-normalize branch May 4, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASPePeX ASPePeX ASPePeX approved these changes

Assignees

@ASPePeX ASPePeX

@wrestledBearOnce wrestledBearOnce

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

float3/4.Normalize.Zero returns float3/4.NaN, should return float3/4.Zero
2 participants
@wrestledBearOnce @ASPePeX