Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

357 remove icons desktop #420

Merged
merged 8 commits into from
Feb 23, 2022
Merged

357 remove icons desktop #420

merged 8 commits into from
Feb 23, 2022

Conversation

wrestledBearOnce
Copy link
Member

@wrestledBearOnce wrestledBearOnce commented Jan 24, 2022 •
edited
Loading

  • Removed all dependencies to System.Drawing in examples
  • Removed all icon code from all examples
  • Re-enabled icons for nearly all examples (except wpf & pointcloud)
  • Changed wrong description for verb player within tools/fusee.exe
  • Fixed ComputeFractal example
  • Started all examples, once

closes #360
closes #357

@wrestledBearOnce wrestledBearOnce changed the base branch from master to develop January 24, 2022 09:56
@wrestledBearOnce wrestledBearOnce self-assigned this Jan 24, 2022
@wrestledBearOnce wrestledBearOnce added bug prio-must Must be implemented labels Jan 24, 2022
@wrestledBearOnce wrestledBearOnce added this to the Release 0.12 milestone Jan 24, 2022
@wrestledBearOnce wrestledBearOnce marked this pull request as draft January 28, 2022 10:32
@wrestledBearOnce wrestledBearOnce marked this pull request as ready for review January 28, 2022 11:03
ASPePeX
ASPePeX requested changes Feb 4, 2022
View reviewed changes
Copy link
Member

@ASPePeX ASPePeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colours are off (a bit blueish) and there is a vertical flip.

@wrestledBearOnce
Copy link
Member Author

The colours are off (a bit blueish) and there is a vertical flip.

Yes. Should be fixed with the latest push. Thank you, wasn't aware of it...

@ASPePeX ASPePeX merged commit a637399 into develop Feb 23, 2022
@ASPePeX ASPePeX deleted the 357-remove-icons-desktop branch February 23, 2022 18:56
@griestopf griestopf mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASPePeX ASPePeX ASPePeX approved these changes

@RedImp1470 RedImp1470 Awaiting requested review from RedImp1470

Assignees

@wrestledBearOnce wrestledBearOnce

Labels
bug prio-must Must be implemented
Projects
None yet
Milestone
Release 0.12
2 participants
@wrestledBearOnce @ASPePeX