Return DASH manifest as data URI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvffle
approved these changes
Oct 2, 2021
JuniorJPDJ
reviewed
Oct 3, 2021
Thanks, good to know. I'll take care about it in a moment. |
|
@TpmKranz could you rebase on top of master? |
|
Also would be cool if you could reword commit message to conform with conventional commits. Our git log is good example of how it should look like. If you can't do it I can, just say ;) |
If a track's manifest is not a JSON object but a DASH manifest, get_file_url throws. This fix encodes the DASH manifest in a data: URI to allow compatible players to play the track regardless. This is technically not a URL, but compatible players usually don't mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for cases when the manifest is not a JSON object but a b64-encoded DASH manifest. The
datascheme allows to keep the interface ofget_file_urlunchanged. Clients that can't deal with data URIs would've choked on theJSONDecodeErroranyway and those that do will just consume them like URLs. Tested with ffmpeg/ffplay and Clementine, both of which don't mind playing data URIs. MPV, for example, doesn't like them.Linting failed due to files unchanged by me, so I had to turn it off. Sorry about that.