Support Assumed Declaration in MiniRust translation #533
+64
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msprotz
approved these changes
Feb 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in support of scylla, to integrate external (assumed) declarations when transpiling from C to Rust.
This PR translates
DExternaldeclarations in Ast to a newAssumednode in MiniRust.In particular, the translation preserves the mutability that was specified by the external declaration, and uses it for the mutability inference in
OptimizeMiniRust. This behavior is overriden for external, "builtin" definitions.Assumed definitions are then filtered and not extracted to Rust: Rust clients are expected to provide them directly.
The extraction of hacl-rs from Low* remains the same with this PR.