nix: various improvements #3182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- centralize nix expressions in `.nix/` - enable all default systems - format using alejandra - propagate ocaml dependencies
|
Hi! What about splitting the derivation, with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Nix code in various ways.
List of changes:
.nix/nixfmt-rfc-styleI want to point out a regression in this PR: the size of the closure of F*
basically doubles since propagating the dependencies brings back the OCaml
compiler as a dependency. IMO this is a good trade, since compiling generated
OCaml will now just work (tm). Currently, fstar-lib dependencies need to be
manually imported, wich is not intuitive at all.
Also see NixOS/nixpkgs#275924 which motivated me to
do the propagation of fstar-lib dependencies.
cc @W95Psp